Diff tables with misplaced columns #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any insight on this or how it could be improved? Thanks! |
|
Rebased against master. |
|
Rebased again and all is green. 💚 |
|
Cool, thanks for contributing to Cucumber! I was surprised the default behaviour was to let this happen, but it's a good idea to preserve backwards compatibility I think. |
mattwynne
added a commit
that referenced
this pull request
Apr 21, 2012
Diff tables with misplaced columns
|
Hooray! Thank you. 👏 |
|
Yeah, sorry it took so ridiculously long to merge in. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With an optional
:misplaced_coloption to theCucumber::Ast::Table#diff!method, one can ensure that column headings between the two tables are in the same order.This is useful in a Cucumber step where you'd like to assert the exact contents of an HTML table, including structure. I ran into this in a JavaScript scenario where I test drag-and-drop column reordering.
The new option defaults to
falseso it should not break backwards compatibility.