Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cucumber.yml is loaded/parsed twice #217

Closed
jasonkarns opened this issue Jan 18, 2012 · 7 comments · Fixed by #416
Closed

cucumber.yml is loaded/parsed twice #217

jasonkarns opened this issue Jan 18, 2012 · 7 comments · Fixed by #416
Assignees
Milestone

Comments

@jasonkarns
Copy link
Contributor

The cucumber.yml file is loaded and parsed a second time when Options.parse is called from Options#merge_profiles.

@aslakhellesoy
Copy link
Contributor

Is that a problem? If so, why?

@jasonkarns
Copy link
Contributor Author

It's not really a problem, as much as a code-smell maybe? We first noticed it when we threw some info-level environment logging into our cucumber.yml. We've since moved that out. Still, it's something that clearly goes against the principle of least surprise. I would have never expected a configuration file to be parsed twice for every run.
And as google didn't find many resources describing this behavior, I thought it should at least be discussed.

@aslakhellesoy
Copy link
Contributor

Feel free to send a pull request to improve this. Personally I don't care.

@dkowis
Copy link
Member

dkowis commented Mar 28, 2013

@mattwynne @aslakhellesoy We could just close this? I don't think it's a serious bug, and I don't think I care either :)

@mattwynne
Copy link
Member

I care. I've tried to print messages from cucumber.yml before and been irritated that they appeared twice. And I agree with the OP that it's a code smell.

@tooky
Copy link
Member

tooky commented Mar 28, 2013

I agree with @mattwynne, its the sort of thing that shouldn't be happening.

I have a feeling that I may have seen where this is happening when I was working on #398 - I'll take a look at this and see what I can do.

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants