-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cucumber.yml is loaded/parsed twice #217
Comments
Is that a problem? If so, why? |
It's not really a problem, as much as a code-smell maybe? We first noticed it when we threw some info-level environment logging into our cucumber.yml. We've since moved that out. Still, it's something that clearly goes against the principle of least surprise. I would have never expected a configuration file to be parsed twice for every run. |
Feel free to send a pull request to improve this. Personally I don't care. |
@mattwynne @aslakhellesoy We could just close this? I don't think it's a serious bug, and I don't think I care either :) |
I care. I've tried to print messages from cucumber.yml before and been irritated that they appeared twice. And I agree with the OP that it's a code smell. |
I agree with @mattwynne, its the sort of thing that shouldn't be happening. I have a feeling that I may have seen where this is happening when I was working on #398 - I'll take a look at this and see what I can do. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The cucumber.yml file is loaded and parsed a second time when Options.parse is called from Options#merge_profiles.
The text was updated successfully, but these errors were encountered: