Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raises exception when remote socket end disconnects #348

Merged
merged 1 commit into from
Feb 25, 2013
Merged

raises exception when remote socket end disconnects #348

merged 1 commit into from
Feb 25, 2013

Conversation

rdammkoehler
Copy link
Contributor

When using Cucumber Wire Protocol with Cucumber CPP if the WireServer crashes (SEGFAULT) during a step the client is left with a nil message returned (IO.gets Returns nil if called at end of file.).

I've added a check for nil that raises a WireException in this case indicating that the remote server hung up.

Appropriate test included.

@mattwynne
Copy link
Member

Thanks for contributing!

On 11 Dec 2012, at 03:48, Rich Dammkoehler wrote:

When using Cucumber Wire Protocol with Cucumber CPP if the WireServer crashes (SEGFAULT) during a step the client is left with a nil message returned (IO.gets Returns nil if called at end of file.).

I've added a check for nil that raises a WireException in this case indicating that the remote server hung up.

Appropriate test included.

You can merge this Pull Request by running:

git pull https://github.com/rdammkoehler/cucumber fix_remote_wire_fail_error
Or view, comment on, or merge it at:

cucumber/common#348

Commit Summary

raises exception when remote socket end disconnects
File Changes

M lib/cucumber/wire_support/connection.rb (1)
M spec/cucumber/wire_support/connection_spec.rb (16)
Patch Links

https://github.com/cucumber/cucumber/pull/348.patch
https://github.com/cucumber/cucumber/pull/348.diff

Reply to this email directly or view it on GitHub.

cheers,
Matt

Freelance programmer & coach
Author, http://pragprog.com/book/hwcuc/the-cucumber-book
Teacher, http://bddkickstart.com
Founder, http://www.relishapp.com/
Twitter, https://twitter.com/mattwynne

mattwynne added a commit that referenced this pull request Feb 25, 2013
raises exception when remote socket end disconnects
@mattwynne mattwynne merged commit 3f1c34b into cucumber:master Feb 25, 2013
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants