Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling #puts in an After hook does not print into the HTML report #731

Closed
mattwynne opened this issue Sep 4, 2014 · 2 comments · Fixed by #746
Closed

Calling #puts in an After hook does not print into the HTML report #731

mattwynne opened this issue Sep 4, 2014 · 2 comments · Fixed by #746
Labels
🐛 bug Defect / Bug 🚦 needs tests Needs tests

Comments

@mattwynne
Copy link
Member

Possibly other formatters too

@mattwynne mattwynne added this to the 2.0 milestone Sep 4, 2014
@brasmusson
Copy link
Contributor

That the output from After hooks and AfterSteps hooks does not end up in the report, is fixed by the commit cucumber/common@2c835c5 in #732, with that change we are back to v1.3.x behavior, that the output from the After/AfterStep hooks ends up in the next Scenario/Step.

However, since #706 was merged, the output from step/hooks is now passed on to the JSON formatter (in the Gherkin library), merging that commit (and thereby fixing the regression from v1.3.x with respect to the HTML and Pretty formatters), will make the JSON formatter crash on output from Before hooks. Since #701 is included in v1.3.16, this problem should/is likely to happen there to.

The short term fix is likely to block or delay output from before hooks, in the gherkin_formatter_adapter, mainly because releasing a new version of the Gherkin library is a complicated process.

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Defect / Bug 🚦 needs tests Needs tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants