Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need Travis ruby 2.0 test? Nokogiri 1.7 requires Ruby 2.1. #1068

Closed
junaruga opened this issue Jan 9, 2017 · 2 comments
Closed

Need Travis ruby 2.0 test? Nokogiri 1.7 requires Ruby 2.1. #1068

junaruga opened this issue Jan 9, 2017 · 2 comments

Comments

@junaruga
Copy link
Contributor

junaruga commented Jan 9, 2017

Summary

Nokogiri 1.7 looks requiring "ruby version >= 2.1.0"
How to fix Travis test for ruby2.0?

Expected Behavior

Current Behavior

https://travis-ci.org/cucumber/cucumber-ruby/jobs/190347224

$ ruby --version

ruby 2.0.0p598 (2014-11-13 revision 48408) [x86_64-linux]
...
nokogiri-1.7.0.1 requires ruby version >= 2.1.0, which is incompatible with the current version, ruby 2.0.0p598

Possible Solution

  • Use latest version nokogiri 1.7.x. And stop support for ruby 2.0. Remove ruby 2.0 from .travis.yml.
    or
  • Use old verson nokogiri 1.6. For example, update cucumber.gemspec from '~> 1.5' to ~> 1.6.0

Steps to Reproduce (for bugs)

Just run travis test for ruby2.0.

Context & Motivation

We are happy for the contribution if we can pass all the tests for Travis CI.

Your Environment

My local environment is

mattwynne added a commit that referenced this issue Jan 21, 2017
@mattwynne
Copy link
Member

Thanks for logging this @junaruga, appreciated :) 👍

@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants