Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version in the logs should not include git commit hash #344

Open
Conjur-oss opened this issue Jun 27, 2021 · 1 comment
Open

Version in the logs should not include git commit hash #344

Conjur-oss opened this issue Jun 27, 2021 · 1 comment

Comments

@Conjur-oss
Copy link
Collaborator

Conjur-oss commented Jun 27, 2021

##Bug description
Currently, when we print the project's version, we print also the commit hash:
{code:java}
 INFO: 2020/11/10 15:32:04 main.go:20: CyberArk Secrets Provider for Kubernetes v1.1.0-e58708b starting up...{code}
{{}}
Fixed versions should not include the git commit tag and should include only the version.

Note: Once we fix this, we should also fix [this issue|https://github.com//issues/256] in the secrets-provider as it has a similar mechanism.
h2. Steps to Reproduce

Steps to reproduce the behavior:

run 

{code:java}
docker pull cyberark/secrets-provider-for-k8s:1.1.0{code}

run 

{code:java}
docker run cyberark/secrets-provider-for-k8s:1.1.0{code}

h2. Expected Results

The log shows the message {{}}
{code:java}
CyberArk Secrets Provider for Kubernetes v1.1.0 starting up...{code}
{{}}
h2. Actual Results (including error logs, if applicable)

The log shows the message {{}}
{code:java}
CyberArk Secrets Provider for Kubernetes v1.1.0-e58708b starting up...{code}
{{}}
h2. Reproducible

  •  Always

h2. Version/Tag number

1.1.0

##Found in version
12.0

##Workaround Complexity
No workaround

##Workaround Description

##Affects Version/s

##Link to JIRA bug
ONYX-9877

@Conjur-oss
Copy link
Collaborator Author

//Author: [email protected]

The original bug opened in github and contain comments [here|https://github.com//issues/258]

@cyberark cyberark deleted a comment from Conjur-oss Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant