You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That would require adding another parameter name to makeTimeTravel, but should suffice.
PS: it really looks like makeTimeTravel is just another nested dialogue. Meaning it's a Cycle.js component. I prefer the name timeTravel instead of makeTimeTravel (the former is a dialogue function, the latter sounds like a factory, reminds me of driver factories). I'm also more and more considering to use an uppercase naming convention for dialogues (TimeTravel, MagicButton, MyFavoriteComponent, etc), I know this convention is normally used for OOP in JavaScript, but Cycle.js isn't anyway OOP. Well, I'm going too far with this PS.
The text was updated successfully, but these errors were encountered:
I had designed makeTimeTravel to loosely follow the nested dialogue pattern. The reason it's named makeTimeTravel is because it has a child property called timeTravel and the user can't name the returned object timeTravel.
I actually quite like the idea of using UpperCase. Maybe something like:
Currently the implementation does
DOM.get('.stream', 'mousemove')
which is dangerous in case the application has elements with classnamestream
. To avoid this global problem, you can use namespaced nested dialogues. Read here http://staltz.com/unidirectional-user-interface-architectures.html and see this example: https://github.com/cyclejs/todomvc-cycle/blob/master/src/components/todo-item.js#L5-L7That would require adding another parameter
name
tomakeTimeTravel
, but should suffice.PS: it really looks like
makeTimeTravel
is just another nested dialogue. Meaning it's a Cycle.js component. I prefer the nametimeTravel
instead ofmakeTimeTravel
(the former is a dialogue function, the latter sounds like a factory, reminds me of driver factories). I'm also more and more considering to use an uppercase naming convention for dialogues (TimeTravel
,MagicButton
,MyFavoriteComponent
, etc), I know this convention is normally used for OOP in JavaScript, but Cycle.js isn't anyway OOP. Well, I'm going too far with this PS.The text was updated successfully, but these errors were encountered: