Update FindCyclus.cmake #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Status Report - 28997d1 - 2024-04-17 21:58:19 -0500Build
|
gonuke
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A handful of changes to the CMake build in this PR.
As mentioned in #1737 we currently export
LD_LIBRARY_PATHwhich helps the linker find all the libraries cycamore needs to link against. When cyclus is built with cython it builds three shared objects (eventhooks.so,pyinfile.so, andpymodule.so) that cycamore needs to be linked against. The current implementation ofFindCyclus.cmakedoes not report these three libraries - this PR modifiesFindCyclus.cmaketo find them if they exist and ignores their lack of existence (in the case that cyclus was not built with python support).A small change with how we handle the coin libraries. Should only be included in the build if the
--allow-milpsflag was setUpdates some outdated variables with respect to
FindPython