Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] MPV Thumbnail script functionality #16

Closed
lenicyl opened this issue Apr 28, 2022 · 8 comments · Fixed by #29
Closed

[Feature Request] MPV Thumbnail script functionality #16

lenicyl opened this issue Apr 28, 2022 · 8 comments · Fixed by #29
Labels
enhancement New feature or request

Comments

@lenicyl
Copy link

lenicyl commented Apr 28, 2022

MPV thumbnail script basically shows preview thumbnails when hovering over mpv's seekbar.

It does not work with MordenX and appears broken, which is believe is due to the fact that it replaces the built-in OSC, which conflicts with MordenX.

I just wanted to know if it was possible to somehow use this script with mordenX, or maybe add its functionality ?

Thank you !

@couleurm
Copy link

couleurm commented Jun 3, 2022

MordenX for the looks, mpv-thumbnail-script for the convenience, would be great to have both 👍

@lostb053
Copy link

Precisely, I'd love to see that too.

@winkyc
Copy link
Collaborator

winkyc commented Aug 14, 2022

I've made a quick and dirty thumbnailer implementation here: winkyc@5cb7fa6
It's based a downstream thumbnailer implementation from dexeonify/mpv-config@2b6e2b2, and seems to work great with the Thumbnailer.lua and Thumbnailer_Worker.lua files from https://github.com/deus0ww/mpv-conf/tree/master/scripts.

image

Perhaps we could get a branch going and get it implemented properly here?

@dexeonify
Copy link

The same method can be applied to mpv_thumbnail_script btw. Diffing the Thumbnailer’s OSC and mpv’s osc.lua, then apply the diffs to MordenX’s OSC.

@NaiveInvestigator
Copy link

Or we could also try out integrating this script too.
https://github.com/po5/thumbfast

@cyl0 cyl0 added the enhancement New feature or request label Oct 2, 2022
@cyl0
Copy link
Owner

cyl0 commented Oct 2, 2022

This would be a nice feature to have, I've created a branch.

@winkyc
Copy link
Collaborator

winkyc commented Oct 15, 2022

The thumbnailer-dev branch should now have a thumbfast implementation.

@winkyc
Copy link
Collaborator

winkyc commented Oct 15, 2022

It currently doesn't scale with the rest of the UI at all since its size is determined by thumbfast. I'll have to look into it further to see if we can get the thumbnail to scale properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants