Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buttons not rendering on click while the video is paused #8

Closed
computator1200 opened this issue Feb 24, 2022 · 8 comments
Closed

buttons not rendering on click while the video is paused #8

computator1200 opened this issue Feb 24, 2022 · 8 comments

Comments

@computator1200
Copy link

computator1200 commented Feb 24, 2022

while the video is paused, the window control buttons (from the osc) and the play button won't show that same darkening effect when you click them. It only works while the video isn't paused, is there any way to fix this? @cyl0

I'm using windows 10.0.19043.1526

@cyl0
Copy link
Owner

cyl0 commented Feb 27, 2022

What exactly do you mean by the darkening effect? If by "darkening effect" you mean the greying out of the icon on click like in this screenshot, then I can't seem to replicate your issue.
Untitled

What build of MPV are you using?

@computator1200
Copy link
Author

computator1200 commented Feb 27, 2022

What exactly do you mean by the darkening effect? If by "darkening effect" you mean the greying out of the icon on click like in this screenshot, then I can't seem to replicate your issue. Untitled

What build of MPV are you using?

yes that, it doesn't become grey, I'm using mpv 0.34.0
I just updated mpv and the issue is still there

could you also try clicking the window control buttons while the video is paused and see if they grey out or not

@computator1200
Copy link
Author

computator1200 commented Feb 27, 2022

ok it's working now, turns out I changed the seekbarfg color to green and that messed it up.

I had changed the line
SeekbarFg = '{\\blur1\\bord1\\1c&H58C41C&}',
with
SeekbarFg = '{\\blur1\\bord1\\1c&HE39C42&}',

Btw is there a way to change the color without this problem happening. How exactly did you set the color for the seekbar.

@cyl0
Copy link
Owner

cyl0 commented Feb 27, 2022

Well that's strange, I'll have to look into this further.

@computator1200
Copy link
Author

computator1200 commented Feb 27, 2022

ok it's working now, turns out I changed the seekbarfg color to green and that messed it up.

I had changed the line SeekbarFg = '{\\blur1\\bord1\\1c&H58C41C&}', with SeekbarFg = '{\\blur1\\bord1\\1c&HE39C42&}',

Btw is there a way to change the color without this problem happening. How exactly did you set the color for the seekbar.

nevermind it wasn't working, even with the script installed fresh along with the font, the same issue appears.

The buttons don't grey out if pressed while the video is paused.

@dexeonify
Copy link

These two commits from upstream osc.lua seems to fix it for me locally.
mpv-player/mpv@48f3a26
mpv-player/mpv@89efe82

@cyl0
Copy link
Owner

cyl0 commented Mar 1, 2022

@computator1200 I've merged the upstream osc.lua patches, could you check if the issue still persists?

@computator1200
Copy link
Author

computator1200 commented Mar 1, 2022

@computator1200 I've merged the upstream osc.lua patches, could you check if the issue still persists?

I've tried the updated mordenx.lua script and it works now, thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants