Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert https://on.cypress.io/ local target links to full local #6061

Merged

Conversation

MikeMcC399
Copy link
Contributor

Issue

Source links stored in *.mdx files with the Cypress redirect server https://on.cypress.io/ that redirect to https://docs.cypress.io/ do not allow transparent testing by Docusaurus. Incorrect redirection links, such as https://on.cypress.io/github#Pull-request-comments which produces a "HTTP 404 not found" error, go undetected as Docusaurus only checks local links.

Change

Links such as https://on.cypress.io/discord or https://on.cypress.io/cloud, that redirect to another domain, are left unchanged.

Also in code example comments, links such as // see: https://on.cypress.io/mounting-react are valid and left unchanged.

From To
https://on.cypress.io/slack-integration /cloud/integrations/slack
https://on.cypress.io/github-integration /cloud/integrations/source-control/github
https://on.cypress.io/gitlab-integration /cloud/integrations/source-control/gitlab
https://on.cypress.io/bitbucket-integration /cloud/integrations/source-control/bitbucket
https://on.cypress.io/root /api/commands/root
https://on.cypress.io/find /api/commands/find
https://on.cypress.io/code-coverage /app/tooling/code-coverage
https://on.cypress.io/how-do-i-record-runs /cloud/get-started/setup
https://on.cypress.io/github#Pull-request-comments /cloud/integrations/source-control/github#Pull-request-comments
https://on.cypress.io/command-line#cypress-info /app/references/command-line#cypress-info
https://on.cypress.io/selecting-elements /app/core-concepts/best-practices#Selecting-Elements
https://on.cypress.io/debug-page /app/core-concepts/open-mode#Debug
https://on.cypress.io/component-integrations /app/component-testing/custom-frameworks
https://on.cypress.io/api/custom-queries /api/cypress-api/custom-queries
https://on.cypress.io/keyboard-api /api/cypress-api/keyboard-api
https://on.cypress.io/writing-and-organizing-tests#Allowed-config-values /app/core-concepts/writing-and-organizing-tests#Allowed-config-values
https://on.cypress.io/cloud-introduction /cloud/get-started/introduction
https://on.cypress.io/changelog#12-0-0 /app/references/changelog#12-0-0
https://on.cypress.io/projects#Change-project-access /cloud/account-management/projects#Change-project-access
https://on.cypress.io/cloud-faq#What-counts-as-a-test-result /cloud/faq#What-counts-as-a-test-result
https://on.cypress.io/IDE-integration#File-Opener-Preference /app/tooling/IDE-integration#File-Opener-Preference
https://on.cypress.io/changelog#12-4-0 /app/references/changelog#12-4-0

Dead links

The following are dead links previously used in docs.cypress.io. They may need correction in the service responsible for on.cypress.io.

[✖] https://on.cypress.io/github#Pull-request-comments → Status: 404
[✖] https://on.cypress.io/projects#Change-project-access → Status: 404
[✖] https://on.cypress.io/cloud-faq#What-counts-as-a-test-result → Status: 404

Copy link

netlify bot commented Dec 28, 2024

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 6b0a91b

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399 MikeMcC399 marked this pull request as ready for review December 28, 2024 19:38
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! This is a huge help. Thank you!

@jennifer-shehane jennifer-shehane merged commit 55f4e91 into cypress-io:main Dec 30, 2024
7 checks passed
@MikeMcC399 MikeMcC399 deleted the links-on.cypress-to-local branch December 30, 2024 15:09
@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

Yay! This is a huge help. Thank you!

You're welcome! The links are now cleaner and maintenance should be more reliable in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants