-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print reasons why Cypress considers an element 'visible' in errors. #677
Comments
Just ran into this issue. I agree that logging a specific reason (opacity) allows the user some context to why the the assertion failed. If such logging isn't a priority, perhaps even a mention in documentation about this caveat could be useful? |
This will probably be a deciding factor if we use cypress as our go-to ui testing tool very very soon. plz help |
Also ran into this now. For performance we show/hide elements with I'd consider that a bug. |
Also running into this right now. I agree opacity 0 element should not be considered visible/clickable. Definitely a bug IMO. Is there a way to work around this? Like by adding some sort of Thanks! |
Hmm I did find this article which makes the point that elements with opacity 0 do still take up space on the page so considering them not visible might not quite be correct.. https://davidwalsh.name/offsetheight-visibility |
@tnrich does that mean that |
I have |
@qodesmith Please open an issue with a complete reproducible example of this so we can fix it. |
@jennifer-shehane I'm so sorry, I take it back. My element had |
Closing due to inactivity. |
Is this a Feature or Bug?
Feature
Current behavior:
When I assert that an element
.should('not.be.visible')
, but Cypress finds that it is visible, it doesn't tell me why it considered the element visible.Error: why does Cypress think it's visible??
Desired behavior:
Cypress should explicitly print the reasons for why Cypress considers an element 'visible' when it fails
.should('not.be.visible')
assertion (just as it does for when it fails.should('be.visible')
).My specific use case had to do with an element on my page having a style of
{opacity: 0}
. So, to me, the element seems to not be visible and I expected a.should('not.be.visible')
assertion to pass.After speaking with the Cypress team, the current behavior is correct however. Since the browser actually allows users to interact with elements that have
{opacity:0}
and Cypress uses this visibility algorithm to determine if elements are intractable, they do not intend to change this behavior.The list of reasons for why Cypress considers something visible may have a specific message about opacity listed first?
How to reproduce:
Reasons why an element is considered visible
Reasons why an element is considered not visible
The text was updated successfully, but these errors were encountered: