Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config:set command doesn't match up characters #37

Open
davewongillies opened this issue Feb 27, 2018 · 0 comments
Open

config:set command doesn't match up characters #37

davewongillies opened this issue Feb 27, 2018 · 0 comments

Comments

@davewongillies
Copy link

davewongillies commented Feb 27, 2018

When using the config:set command with a value that contains a hash and an array, such as:

hubot heroku config:set my_app HUBOT_GITHUB_REPOS_MAP={"web":["frontend","web"],"android":["android"],"ios":["ios"],"platform":["web"]}

The regex in scripts/heroku-commands.js#L235 doesn't match up on the last 3 characters, resulting in a broken config setting.

But if I wrap it up in double quotes:

hubot heroku config:set my_app HUBOT_GITHUB_REPOS_MAP="{"web":["frontend","web"],"android":["android"],"ios":["ios"],"platform":["web"]}"

Its OK, since the matches on \b.

I'm not sure what the best way to fix this is. The easiest is just to drop the \b from the regex but I'm not entirely sure why it was added in the first place (I'm assuming it was to catch some edge case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant