Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary pyenv usage in environment setup #26078

Open
deepyaman opened this issue Nov 21, 2024 · 0 comments · May be fixed by #26090
Open

Avoid unnecessary pyenv usage in environment setup #26078

deepyaman opened this issue Nov 21, 2024 · 0 comments · May be fixed by #26090
Labels
area: docs Related to documentation in general

Comments

@deepyaman
Copy link
Contributor

What's the issue or suggestion?

Going through https://docs.dagster.io/community/contributing, it seems pyenv is used to create an isolated environment, inside of which uv is installed. Since uv can also be used to create virtual environments, it makes sense to just install uv first (no Homebrew necessary!) and use it all the way. Realistically, all that changes in scripts/install_dev_python_modules.py is that the following lines can be removed:

-    # Ensure uv is installed which we use for faster package resolution
-    subprocess.run(["pip", "install", "-U", "uv"], check=True)
-

I think it would also require some (minimal) changes to python_modules/automation/automation/docker/images/buildkite-test/Dockerfile.

Happy to make a PR, if this makes sense!

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
1 participant