Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variable DAGU_BASE_URL #576

Closed
yohamta opened this issue May 30, 2024 · 2 comments · Fixed by #714
Closed

Add environment variable DAGU_BASE_URL #576

yohamta opened this issue May 30, 2024 · 2 comments · Fixed by #714
Labels
enhancement New feature to be implemented soon

Comments

@yohamta
Copy link
Collaborator

yohamta commented May 30, 2024

Currently, Dagu is unable to run behind a proxy. To address this, we need to introduce a new environment variable that allows specifying a different base URL for Dagu.

New environment variable: DAGU_BASE_URL

Additional Context

@yohamta yohamta added good first issue Good for newcomers enhancement New feature to be implemented labels May 30, 2024
@yohamta yohamta added this to the 1.14 milestone Jul 15, 2024
@yohamta yohamta removed this from the 1.13.2 milestone Jul 24, 2024
@yohamta yohamta added soon and removed good first issue Good for newcomers labels Oct 2, 2024
@chrishoage
Copy link
Contributor

Is this actively being worked on?

I am currently evaluating this tool for solving some problems, and I require it to exist behind a reverse proxy.

If no one is actively working on this issue I may pick it up if my evaluation ends up with me accepting this tool. I just don't want to double up work if somebody is already actively solving this problem.

If you are seeking third party support for implementing this feature do you have any suggestions on the approach that you would deem most acceptable?

@yohamta
Copy link
Collaborator Author

yohamta commented Nov 14, 2024

@chrishoage Yes, that would be great, thanks! :) I believe no one is actively working on this at the moment.

Here are the files that need modification:

  1. config.go: config.go

    • Add a configuration key, BaseURL
    • Add a environment variable mapping for baseURL and DAGU_BASE_URL in here.
  2. templates.go: templates.go

    • Modify the apiURL function to return path.Join(cfg.BaseURL, cfg.APIBaseURL) instead of cfg.APIBaseURL.

Thanks again for considering this! Let me know if you need any more details or help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature to be implemented soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants