LUA mod:getMidiMessage():getProperty("midiMessageCtrlrNumber") crashing on PC

[damiensellier]

local myNumber = mod:getMidiMessage():getProperty("midiMessageCtrlrNumber")
crashes on v5.6 on Windows. It works in 5.3.201.

NOTE : All mod:getMidiMessage():getProperty() won't work on macOS and will return :

Error message: [string "sendCC"]:10: attempt to call method 'getProperty' (a nil value)

sendCC = function(--[[ CtrlrModulator --]] mod --[[ number --]], value --[[ number --]], source)
    if panel:getBootstrapState() then
        return
    end
    local myNumber = mod:getMidiMessage():getProperty("midiMessageCtrlrNumber") -- CRASHES
  -- myNumber=15 -- WORKS
    panel:sendMidiMessageNow(CtrlrMidiMessage(string.format("B0 %.2x %.2x", myNumber, value)))
end

See @dnaldoog test panel for testing : test midiMessageCtrlrNumber_1_0_2024-05-30_11-40.zip

[dobo365]

Will have to check that one...

[damiensellier]

REF : RomanKubiak#619 (comment)

[damiensellier]

Comparer code v5.6.31 avec source v5.3.198

[damiensellier]

NOTE:

Probably comes from a bad LuaBind defintion. Search for wrapForLua CtrlrLuaManager :

void CtrlrModulator::wrapForLua (lua_State *L)
{
	using namespace luabind;

	module(L)
		[
			class_<CtrlrModulator, CtrlrLuaObject>("CtrlrModulator")
// ...
.def("getMidiMessage", (CtrlrMidiMessage &(CtrlrModulator::*)(void))&CtrlrModulator::getMidiMessagePtr)
		.def("getMidiMessage", (CtrlrMidiMessage &(CtrlrModulator::*)(const CtrlrMIDIDeviceType))&CtrlrModulator::getMidiMessagePtr)
// ...

[damiensellier]

CtrlrLuaManager L1143 was commented, I don't remember why :

.def("getProperty", (const var &(CtrlrModulator::*)(const Identifier&) const)&CtrlrModulator::getProperty) // Updated v5.6.31

If uncommented, does not work.

[damiensellier]

CtrlrModulator.cpp has all the mod properties

CtrlrMidiMessage.cpp has all the midiMessage properties
setProperty is declared
but
getProperty is missing ??

requires something like that :

CtrlrMidiMessageType CtrlrMidiMessage::getProperty() const
{
	//
}

[damiensellier]

Different properties of the midi message of the modulator :

  <midi midiMessageType="9" midiMessageChannelOverride="0" midiMessageChannel="1"
        midiMessageCtrlrNumber="1.0" midiMessageCtrlrValue="0" midiMessageMultiList=""
        midiMessageSysExFormula=""/>

[damiensellier]

In Ctrlr 5.3.198 there's extra files for Lua which have been merged and deprecated :

CtrlrModulatorProcessor.cpp
CtrlrModulatorProcessor.h

merged with CtrlrManager.cpp

[damiensellier]

The function getProperty() are the following :

const var &getProperty (const Identifier& name) const
{ 
	return midiTree.getProperty (name); 
}
		
const var getProperty (const Identifier& name, const var &defaultReturnValue) const
{ 
	return midiTree.getProperty (name, defaultReturnValue); 
}

We need to bind them to LUA :

        .def("getProperty", (const var &(CtrlrMidiMessage::*)(const Identifier &) const) &CtrlrMidiMessage::getProperty) // Added v5.6.31

[damiensellier]

FIXED :

test midiMessageCtrlrNumber_1_0_2024-12-17_15-44.panel.zip

--
-- Called when a modulator value changes
-- @mod   http://ctrlr.org/api/class_ctrlr_modulator.html
-- @value    new numeric value of the modulator
--
sendCC = function(--[[ CtrlrModulator --]] mod --[[ number --]], value --[[ number --]], source)
    if panel:getBootstrapState() then
        return
    end
     local messageType = mod:getMidiMessage():getMidiMessageType()
    console("message Type Via getMidiMessageType: "..tostring(messageType))

     local messageTypeViaGetType = mod:getMidiMessage():getType()
    console("messageType Via getType: "..tostring(messageTypeViaGetType))

     local midiControllerNumber = mod:getMidiMessage():getNumber()
    console("midi Controller Number via getNumber: "..tostring(midiControllerNumber))

     local midiValue = mod:getMidiMessage():getValue()
    console("midi Value: "..tostring(midiValue))

     local messageSize = mod:getMidiMessage():getSize()
    console("message Size: "..tostring(messageSize))

     local midiMessageCtrlrNumberViaProp = mod:getMidiMessage():getProperty("midiMessageCtrlrNumber")
     console("midi Controller Number via getProperty: "..tostring(midiMessageCtrlrNumberViaProp))

    panel:sendMidiMessageNow(CtrlrMidiMessage(string.format("B0 %.2x %.2x", midiMessageCtrlrNumberViaProp, value)))
end

Both getNumber and getProperty() work from now on.

[damiensellier]

FIXED IN v5.6.31

NOTE :

CtrlrMidiMessage.h L118

//const var getProperty (const Identifier& name, const var &defaultReturnValue) const { return midiTree.getProperty (name, defaultReturnValue); } // Updated v5.6.31. Useless

CtrlrMidiMessage.cpp L920

        .def("getProperty", (const var &(CtrlrMidiMessage::*)(const Identifier &) const) &CtrlrMidiMessage::getProperty) // Added v5.6.31