Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.devdbrc not detected in multi root projects #68

Closed
bilogic opened this issue Sep 8, 2024 · 6 comments
Closed

.devdbrc not detected in multi root projects #68

bilogic opened this issue Sep 8, 2024 · 6 comments

Comments

@bilogic
Copy link

bilogic commented Sep 8, 2024

Extension Version

1.13.2

OS and Version

Ubuntu 22.04

VS Code Version

1.92.2

Database name and Version

mysql 8.0.37

Steps to reproduce

[
  {
    "name": "My test MySQL database", // <-- to identify the connection
    "type": "mysql", // <- or "mariadb" if you are using MariaDB
    "host": "...",
    "port": "...",
    "username": "...",
    "password": "...",
    "database": "..." // <-- the database to show in VS Code DevDb view
  }
]
{
    "folders": [
        {
            "path": "."
        },
    ]
}

Partial contents of my .code-workspace file. The contents of .devdbrc do not appear in the UI.

Expected behavior

Expected the database connection to show up on the UI

Screenshots

image
Only this appears

Additional context

It might be more apt to have connections stored in the inheritable model of VSCode user/workspace settings.

This has many benefits including allow each developer to have their own DB connection/settings rather than have .devdbrc commited into git

@bilogic bilogic added bug Something isn't working low priority unconfirmed labels Sep 8, 2024
@github-actions github-actions bot added the needs more info Extra attention is needed label Sep 8, 2024
Copy link

github-actions bot commented Sep 8, 2024

Hey @bilogic! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to provide screenshots. A picture is worth more than a thousand words. Please edit your original post and add screenshots, then we'll try and fix this issue.

We need screenshots to make it easier for us to visualize your issue, since your description of this bug as you described above may not paint the full picture. Do ensure that your screenshot does not include anything that should not be made public.

Please upload your screenshot files directly to GitHub.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 8, 2024
@bilogic
Copy link
Author

bilogic commented Sep 8, 2024

Pretty sure I had screenshot attached...

@damms005 damms005 added feature and removed bug Something isn't working needs more info Extra attention is needed unconfirmed labels Sep 10, 2024
@damms005
Copy link
Owner

damms005 commented Sep 10, 2024

Had a snag in the regex used to detect screenshots. It is now fixed and hopefully no more false negatives in detecting screenshots in issues. Sorry about the stress.

Yes, about the multi-root projects support, I totally agree with you and will be a good feature. However, I currently don't have a need for it nor can I commit the time to address it right now.

I have updated the labels for this issue and also added the feature label. I'll hopefully get to add this soon enough in the future. PRs also welcomed! 😍

@bilogic
Copy link
Author

bilogic commented Sep 10, 2024

ok thanks!

@sunilv45
Copy link

Extension Version
v1.13.4

OS and Version
Windows_NT x64 10.0.19045

VS Code Version
Version: 1.93.1

Database name and Version
8.0.31 MySQL

Also configure when not auto detected in root directory of laravel

[
  {
    "name": "My local", // <-- to identify the connection
    "type": "mysql", // <- or "mariadb" if you are using MariaDB
    "host": "localhost", //Also i tried with 127.0.0.1
    "port": "3306",
    "username": "username",
    "password": "mypassword",
    "database": "demo_app" // <-- the database to show in VS Code DevDb view
  }
]

The contents of .devdbrc do not appear in the UI.

Expected behavior to show the UI for mysql with connection

Nothing was showing only sqlite was visible

Screenshots
devdb issue

Only this appears

@damms005
Copy link
Owner

@sunilv45 please do not cross-post, more so this is a closed issue.

Else, subscribers of this thread will get notified of unrelated issue, which is not cool 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants