Cleanup: A bunch of stuff to do before the concert

[danielsomerfield]

Many and varied:

CRITICAL

HIGH

• submitted songs with equal votes / dollar votes should be sorted by timestamp ascending in playlist

Done

• render dollars rather than "votes" on song page
• get rid of scrollbar ghost
  • (deployed fix)
• now playing visual: hide vote count replace with music note
  • (deployed fix)
• Re-ordering is broken, even for non-locked songs. It changes the votes for the moved song. It would be fine to not allow the admin to move unlocked songs if that makes it easier (just allow re-ordering of locked songs, which need not show their amount on the kiosk view)
  • (deployed fix)
• fix sort order on song request list
  • (deployed fix)
• Requester missing on kiosk view and "unknown" on admin view
  • (deployed fix)
  • caveat, it's possible for a non-approved voter to show up if they submit first. Will fix if time permits.
• User playlist has "Up vote" button and it responds with "Your vote has been added". Instead, selecting the button should take the user to the song page, same as touching the song itself. Then they can Venmo more! (It seems good to have the button to let the user know they can give more.)
  • (deployed fix)
• refresh on approve click in dvAdmin
  • (deployed fix)
• locked songs shouldn't show amount/votes in kiosk view, should show a lock or a --
  • (deployed fix)
• zero and negative numbers allowed in requests (negative numbers make it to the approver)
  • (deployed fix)

OTHER

• show toast on errors for new content

[danielsomerfield]

Keeping track of statuses above.