Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No reason for ъ/Ъ/ь/Ь to be in Bulgarian-specific array #190

Open
brandonkelly opened this issue Sep 10, 2018 · 0 comments
Open

No reason for ъ/Ъ/ь/Ь to be in Bulgarian-specific array #190

brandonkelly opened this issue Sep 10, 2018 · 0 comments

Comments

@brandonkelly
Copy link

Stringy::langSpecificCharsArray() defines ASCII counterparts for the following Bulgarian characters: ъ, Ъ, ь, and Ь

However none of those characters have any alternatives in Stringy::charsArray(), which means they will be untouched by Stringy::toAscii() unless $language is set to 'bg'.

As there are no other ASCII equivalents for these characters, I think they should be defined in charsArray() instead.

echo Stringy::create('ъ')->toAscii();
// outputs: 'ъ'
// expected: 'a'

echo Stringy::create('ъ')->toAscii('bg');
// outputs: 'a' (as expected)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant