Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Allow Receiving Cumulative Vote Rewards While Offline #91

Open
UnknownSilicon opened this issue Jun 23, 2023 · 0 comments

Comments

@UnknownSilicon
Copy link

The check cumulative functions (checkDailyCumulative, checkWeeklyCumulative, etc.) in

fun checkDailyCumulative(player: Player)
are only called when a player is online due to this check
val online = player.player ?: return

Since the cumulative checks only see if the player has exactly the correct amount of votes, players do not receive cumulative rewards if they were offline for the last vote. This could be fixed in one of two ways:

  1. Keep track of the cumulative rewards a player did receive and change the cumulative check to check for greater than or equal to the required amount of votes.
  2. Add cumulative rewards to a player's claimable, redeeming them when the player next joins (as shown in this commit ParallelMC@084d78f. This exact solution isn't clean, but it may end up being less data to track).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant