Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding no_wildcard_variable_uses to core #139

Closed
pq opened this issue Jul 19, 2023 · 3 comments · Fixed by #165
Closed

Consider adding no_wildcard_variable_uses to core #139

pq opened this issue Jul 19, 2023 · 3 comments · Fixed by #165

Comments

@pq
Copy link
Member

pq commented Jul 19, 2023

See: dart-lang/sdk#51221

/fyi @munificent

@natebosch
Copy link
Member

natebosch commented Jul 19, 2023

We can't come up with a meaningful name automatically, but would it be worthwhile to try to find a pattern to have a fix with an automatic rename to something non-meaningful (localVar, argument1) or semi-meaningful (maybe a heuristic on the type or something else)?

I think I lean towards not trying to add a fix, I can't recall what portion of our current core set has a fix.

I am in favor of adding this lint to the core set whether we add a fix or not - but if we may add a fix we should hold off on adding it to the core set until we implement it.

@devoncarew devoncarew moved this from Triage backlog to Under consideration in Lints Triage Sep 5, 2023
@devoncarew devoncarew moved this from Under consideration to Approved in Lints Triage Sep 19, 2023
@devoncarew
Copy link
Member

This is approved for the core set.

@devoncarew
Copy link
Member

This lint requires 3.1, which the package currently doesn't set as its minimum.

@devoncarew devoncarew moved this from Approved to Triage backlog in Lints Triage Sep 27, 2023
@devoncarew devoncarew moved this from Triage backlog to Work needed in Lints Triage Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants