Change stdout/stderr to binary mode on Windows

Every other file opened in Windows is in binary mode, and there is no way of opening a file in text mode. This is a breaking change if one is relying on the CR insertion when writing to stdout/stderr on Windows. BUG=#19334 [email protected] Review URL: https://codereview.chromium.org//1228053002.
dart-lang · Jul 10, 2015 · 4205b29 · 4205b29
1 parent fe2c4c5
commit 4205b29
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/runtime/bin/file_win.cc b/runtime/bin/file_win.cc
@@ -196,6 +196,7 @@ File* File::OpenStdio(int fd) {
     default:
       UNREACHABLE();
   }
+  _setmode(fd, _O_BINARY);
   return new File(new FileHandle(fd));
 }
 

diff --git a/tests/standalone/io/stdio_nonblocking_test.dart b/tests/standalone/io/stdio_nonblocking_test.dart
@@ -17,12 +17,7 @@ void main() {
                   print(result.stdout);
                   print(result.stderr);
     Expect.equals(1, result.exitCode);
-    if (Platform.isWindows) {
-      Expect.equals('stdout\r\n\r\ntuodts\r\nABCDEFGHIJKLM\r\n', result.stdout);
-      Expect.equals('stderr\r\n\r\nrredts\r\nABCDEFGHIJKLM\r\n', result.stderr);
-    } else {
-      Expect.equals('stdout\n\ntuodts\nABCDEFGHIJKLM\n', result.stdout);
-      Expect.equals('stderr\n\nrredts\nABCDEFGHIJKLM\n', result.stderr);
-    }
+    Expect.equals('stdout\n\ntuodts\nABCDEFGHIJKLM\n', result.stdout);
+    Expect.equals('stderr\n\nrredts\nABCDEFGHIJKLM\n', result.stderr);
   });
 }