Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDC] update the module uris in metadata files to match the directory structure #49668

Closed
annagrin opened this issue Aug 15, 2022 · 1 comment
Closed

[DDC] update the module uris in metadata files to match the directory structure #49668

annagrin opened this issue Aug 15, 2022 · 1 comment
Assignees
@annagrin
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dev-compiler web-eval evaluation support on the web

Comments

@annagrin
Copy link
Contributor

annagrin commented Aug 15, 2022 •
edited
Loading

parent: dart-lang/webdev#1692

Proposed fix

make server paths follow directory structure:packages/<package_directory>/

Fix plan

DDC:
update the module uris in metadata files to match the scheme above, under a new debugger-module-uris flag

Note: is it needed? Check is the source map paths are absolute or relative when using build runner to compile the app.
@annagrin annagrin self-assigned this Aug 15, 2022
@annagrin annagrin changed the title [DDC] Expression compiler worker: update the module uris in metadata files to match the directory structure [DDC] update the module uris in metadata files to match the directory structure Aug 19, 2022
@annagrin
Copy link
Contributor Author

Update: looks like this is not necessary in build runner scenario, the new tests in dart-lang/webdev#1730 pass for build runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annagrin annagrin

Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dev-compiler web-eval evaluation support on the web
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@annagrin