Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: remove debugger-module-names flag from all code #49669

Open
annagrin opened this issue Aug 15, 2022 · 1 comment
Open

cleanup: remove debugger-module-names flag from all code #49669

annagrin opened this issue Aug 15, 2022 · 1 comment
Assignees
@annagrin
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. dev-compiler-eval front-end-server Issues with the frontend server web-eval evaluation support on the web

Comments

@annagrin
Copy link
Contributor

annagrin commented Aug 15, 2022 •
edited
Loading

parent issue: dart-lang/webdev#1692

Proposed fix

make server paths follow directory structure:packages/<package_directory>/<path from package root to the file on disk>

Fix plan

  • cleanup:
    • set debugger-module-names to true by default
    • after all the changes propagated to dart and flutter stable versions
      • remove passing of the flag by tools
      • remove the flag
@annagrin annagrin self-assigned this Aug 15, 2022
@lrhn lrhn added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Aug 15, 2022
@annagrin
Copy link
Contributor Author

Update: we might just reuse the existing --debugger-module-names flag instead. THen this issue would be the same as flutter/flutter#52693

@annagrin annagrin changed the title cleanup: remove debugger-module-uris flag from all code cleanup: remove debugger-module-names flag from all code Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annagrin annagrin

Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. dev-compiler-eval front-end-server Issues with the frontend server web-eval evaluation support on the web
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lrhn @annagrin