-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graduate the invalid_runtime_check_with_js_interop_types
lint out of experimental
#56396
Comments
What does this entail? I thought it was connected to the |
I don't know; it shows as experimental here: https://dart.dev/tools/linter-rules/invalid_runtime_check_with_js_interop_types; perhaps there's something still to toggle, or perhaps it's been changed and there's some latency in updating that page. |
I think we need to update the website lints. dart-lang/site-www#6025 this PR landed, but I think the JSON file is old! |
I take that back. I just ran the update script against |
https://github.com/dart-lang/site-www/blob/main/src/_data/linter_rules.json#L1330 – it's updated! hrm... |
is there a cache that's...old? |
I'd guess something similar; I don't think there's anything to update here wrt the impl. or state flag of the lint. |
I'm updating dart.dev in dart-lang/site-www#6033 which will surface it as stable and released in 3.5. I didn't do it right away as I had to account for lints no longer being part of 3 predefined categories. Sorry about the confusion! |
Lints no longer are part of three specific groups, but now have tags/groups (https://github.com/dart-lang/linter/issues/1020). This PR removes the expectation of the three groups so that the lints keep rendering. It also updates the source data to the latest version with no groups. As part of the work in #4499, we'll surface the new categories/tags later on :) Closes dart-lang/sdk#56396
We're considering adding the
invalid_runtime_check_with_js_interop_types
lint to the package:lints lint set; we'd want to graduate the rule out of experimental before that.cc @srujzs
The text was updated successfully, but these errors were encountered: