This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
feat: restructure core status response #107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not nest struct into message and keep fee on top level
shumkov
commented
Mar 17, 2021
Alex-Werner
approved these changes
Mar 18, 2021
Alex-Werner
added a commit
that referenced
this pull request
Mar 18, 2021
This reverts commit af592ea.
Alex-Werner
added a commit
that referenced
this pull request
Mar 18, 2021
* feat: restructure core status response * feat: restructure core status response * feat: restructure core status response * feat: added Masternode and renamed masternode.status to .state * chore: build * feat: restructure core status response * fix: network not defined We should not nest struct into message and keep fee on top level * feat: rename fee to networkfee Co-authored-by: Alex Werner <[email protected]>
Alex-Werner
added a commit
that referenced
this pull request
Mar 18, 2021
This reverts commit af592ea.
shumkov
pushed a commit
that referenced
this pull request
Mar 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
This pull request implements a new structure for core getStatus response.
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only