Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat: add getIdentitiesByPublicKeyHashes method #304

Merged
merged 17 commits into from
Oct 7, 2020

Conversation

jawid-h
Copy link
Contributor

@jawid-h jawid-h commented Sep 21, 2020

Issue being fixed or feature implemented

Adding getIdentitiesByPublicKeyHashes method

What was done?

Added getIdentitiesByPublicKeyHashes method

How Has This Been Tested?

Unit tests.

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h added this to the v0.16 milestone Sep 21, 2020
@lgtm-com
Copy link

lgtm-com bot commented Sep 22, 2020

This pull request introduces 1 alert when merging 3fefee4 into dc3e45c - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@jawid-h jawid-h changed the title feat: add getIdentitiesByPublicKeyHashes and getIdentityIdsByPublicKeyHashes feat: add getIdentitiesByPublicKeyHashes method Sep 22, 2020
@jawid-h jawid-h closed this Oct 6, 2020
@jawid-h jawid-h reopened this Oct 6, 2020
@lgtm-com
Copy link

lgtm-com bot commented Oct 6, 2020

This pull request introduces 1 alert when merging 25fd248 into dc3e45c - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

shumkov
shumkov previously approved these changes Oct 6, 2020
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jawid-h jawid-h merged commit cd8f6a4 into v0.16-dev Oct 7, 2020
@jawid-h jawid-h deleted the feat/getIdentitiesByPublicKeyHashes branch October 7, 2020 11:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants