This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antouhou
previously approved these changes
Oct 14, 2020
shumkov
reviewed
Oct 14, 2020
shumkov
reviewed
Oct 14, 2020
test/unit/grpcServer/handlers/platform/getDocumentsHandlerFactory.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Oct 14, 2020
test/unit/grpcServer/handlers/platform/getDataContractHandlerFactory.js
Outdated
Show resolved
Hide resolved
shumkov
reviewed
Oct 14, 2020
test/unit/grpcServer/handlers/platform/getIdentityHandlerFactory.js
Outdated
Show resolved
Hide resolved
shumkov
changed the title
feat!: use bytes for identifiers
feat!: use Buffers for identifiers
Oct 14, 2020
shumkov
previously approved these changes
Oct 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
shumkov
changed the title
feat!: use Buffers for identifiers
chore: update to new Drive endpoints
Oct 21, 2020
antouhou
approved these changes
Oct 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Drive 0.16 changes format of query endpoints
What was done?
Update requests to Drive query endpoints to follow new format.
How Has This Been Tested?
With tests
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only