Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat: throw GrpcError if state transaction was broadcasted twice #328

Merged
merged 1 commit into from
Dec 28, 2020
Merged

feat: throw GrpcError if state transaction was broadcasted twice #328

merged 1 commit into from
Dec 28, 2020

Conversation

shuplenkov
Copy link
Member

Issue being fixed or feature implemented

If state transaction was broadcasted twice, we get Internal error

What was done?

Fixed broadcastStateTransitionHandler to throw correct error

How Has This Been Tested?

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.17 milestone Dec 25, 2020
@shuplenkov shuplenkov merged commit 3f99bdf into v0.17-dev Dec 28, 2020
@shuplenkov shuplenkov deleted the error-on-double-broadcast branch December 28, 2020 07:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antouhou antouhou antouhou approved these changes

@shumkov shumkov Awaiting requested review from shumkov

Assignees
No one assigned
Labels
None yet
Milestone
v0.17
Development

Successfully merging this pull request may close these issues.
2 participants
@shuplenkov @antouhou