Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

fix(core)!: timeOffset on getStatus expected to be uint32 #332

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jan 19, 2021

Issue being fixed or feature implemented

Time offset from Insight is -1 but unsign integer is expected

What was done?

Removed time offset field from getStatus response

How Has This Been Tested?

Breaking Changes

The time offset is nil always.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v0.17.x milestone Jan 19, 2021
@shumkov shumkov requested a review from Cofresi January 19, 2021 17:15
@shumkov shumkov changed the title fix(core)!: timeOffset from Insight on getStatus expected to be uint32 fix(core)!: timeOffset on getStatus expected to be uint32 Jan 19, 2021
Copy link
Contributor

@Cofresi Cofresi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@shumkov shumkov merged commit 9486de8 into master Jan 19, 2021
@shumkov shumkov deleted the fix-get-status branch January 19, 2021 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants