Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

refactor: getRawTransaction without insight #345

Merged
merged 9 commits into from
Mar 9, 2021
Merged

refactor: getRawTransaction without insight #345

merged 9 commits into from
Mar 9, 2021

Conversation

Alex-Werner
Copy link
Contributor

@Alex-Werner Alex-Werner commented Mar 1, 2021 •
edited
Loading

Issue being fixed or feature implemented

Support for getRawTransaction without insight dependency

What was done?

  • feat: provide getRawTransaction using coreRPCClient instead of insight

How Has This Been Tested?

  • using current test suite with updated mocks

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Alex-Werner Alex-Werner marked this pull request as ready for review March 1, 2021 12:34
@shumkov shumkov changed the base branch from v0.18-dev to v0.19-dev March 3, 2021 07:42
@shumkov shumkov added this to the v0.19 milestone Mar 3, 2021
@shumkov shumkov changed the title feat: provide getRawTransaction without insight refactor: getRawTransaction without insight Mar 9, 2021
@Alex-Werner Alex-Werner requested a review from shumkov March 9, 2021 06:13
shumkov
shumkov approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@shumkov shumkov merged commit 5c2d440 into v0.19-dev Mar 9, 2021
@shumkov shumkov deleted the feat/get-transaction branch March 9, 2021 06:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shumkov shumkov shumkov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.19
Development

Successfully merging this pull request may close these issues.
2 participants
@Alex-Werner @shumkov