Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat!: reimplement getStatus without Insight API #347

Merged
merged 41 commits into from
Apr 21, 2021
Merged

feat!: reimplement getStatus without Insight API #347

merged 41 commits into from
Apr 21, 2021

Conversation

Alex-Werner
Copy link
Contributor

@Alex-Werner Alex-Werner commented Mar 1, 2021 •
edited by shumkov
Loading

Issue being fixed or feature implemented

Implements getStatus without using insight and dashcore-node.

What was done?

  • Use Core directly to get status information
  • Restructure response format

How Has This Been Tested?

With unit tests

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Alex-Werner Alex-Werner changed the title feat: add getStatus method feat!: add getStatus method Mar 1, 2021
@Alex-Werner Alex-Werner added this to the v0.18 milestone Mar 1, 2021
@shumkov shumkov changed the base branch from v0.18-dev to v0.19-dev March 3, 2021 07:42
@shumkov shumkov modified the milestones: v0.18, v0.19 Mar 3, 2021
@lgtm-com
Copy link

lgtm-com bot commented Mar 11, 2021

This pull request introduces 2 alerts when merging a363ae5 into 5376748 - view on LGTM.com

new alerts:

  • 1 for Non-linear pattern
  • 1 for Unused variable, import, function or class

Alex-Werner and others added 16 commits March 11, 2021 10:46
@Alex-Werner
feat: removed getStatus in favor of two separate call
1c1e2b5
@Alex-Werner
feat: update getStatusHandler
2c89b09
@Alex-Werner
feat: use temporary branch
a67fe71
@Alex-Werner
chore: force https for dependency
1ea1eac
@antouhou
Merge remote-tracking branch 'origin/feat/get-status' into feat/get-s…
ceb58a5 
…tatus

# Conflicts:
#	lib/externalApis/dashcore/rpc.js
#	lib/grpcServer/handlers/core/getStatusHandlerFactory.js
@antouhou
update lock file
1b0478c
@Alex-Werner
feat: added getMnSync and getMasternode rpc
6457c0f
@Alex-Werner
feat: provide mnSync and masternode status response
a8c8e98
@antouhou
useless commit to restart the build
129befc
@antouhou
Merge remote-tracking branch 'origin/feat/get-status' into feat/get-s…
3233bde 
…tatus
@antouhou
remove useless commit
369d506
@Alex-Werner
test: provide coverage for getStatus
a7b77b6
@Alex-Werner
fix: state -> status
9cca8ee
@antouhou
update dapi-client to 0.18.0 to fix docker build
21e1b0c
@antouhou
Merge remote-tracking branch 'origin/feat/get-status' into feat/get-s…
be2e327 
…tatus
@Alex-Werner
tests: fixed get network
d5ee046
@Alex-Werner Alex-Werner requested a review from antouhou March 18, 2021 16:27
@shumkov shumkov changed the title feat!: add getStatus method feat!: improve getStatus method Mar 23, 2021
@shumkov shumkov changed the title feat!: improve getStatus method feat!: restructure getStatus endpoint Mar 23, 2021
@shumkov shumkov changed the title feat!: restructure getStatus endpoint feat!: reimplement getStatus without Insight API Mar 23, 2021
This was referenced Mar 23, 2021
Merged
Merged
shumkov
shumkov previously approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

shumkov
shumkov approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit 20d8ea9 into v0.19-dev Apr 21, 2021
@shumkov shumkov deleted the feat/get-status branch April 21, 2021 09:46
@shumkov shumkov restored the feat/get-status branch April 21, 2021 10:00
@shumkov shumkov deleted the feat/get-status branch May 5, 2021 20:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shumkov shumkov shumkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Milestone
v0.19
Development

Successfully merging this pull request may close these issues.
3 participants
@Alex-Werner @shumkov @antouhou