Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat!: add more information to proofs #373

Merged
merged 12 commits into from
Jun 29, 2021
Merged

feat!: add more information to proofs #373

merged 12 commits into from
Jun 29, 2021

Conversation

jawid-h
Copy link
Contributor

@jawid-h jawid-h commented Jun 17, 2021 •
edited by shumkov
Loading

Issue being fixed or feature implemented

To provide metadata and more information with proofs for platform endpoints. Since proofs include data already it shouldn't be sent in case of proof is requested. dashevo/js-drive#518

What was done?

  • updated dapi-grpc
  • updated Drive client to handle both Protobuf and CBOR responses
  • updated query handlers

How Has This Been Tested?

Unit tests

Breaking Changes

Data is nil in case if a proof is requested from platform endpoints

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@jawid-h jawid-h requested review from shumkov and shuplenkov June 17, 2021 05:07
@jawid-h jawid-h marked this pull request as ready for review June 17, 2021 05:42
shumkov
shumkov suggested changes Jun 17, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update waitForStateTransitionResult as well

lib/grpcServer/handlers/platform/getDataContractHandlerFactory.js Show resolved Hide resolved
@jawid-h jawid-h requested a review from shumkov June 18, 2021 05:58
@jawid-h jawid-h requested a review from shumkov June 18, 2021 09:50
@shumkov shumkov self-requested a review June 29, 2021 10:43
shumkov
shumkov approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov changed the title feat: add more information to proofs feat!: add more information to proofs Jun 29, 2021
@shumkov shumkov added this to the v0.20 milestone Jun 29, 2021
@shumkov shumkov merged commit 93e0a58 into v0.20-dev Jun 29, 2021
@shumkov shumkov deleted the feat/more-proofs branch July 22, 2021 12:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shumkov shumkov shumkov approved these changes

@shuplenkov shuplenkov Awaiting requested review from shuplenkov

Assignees
No one assigned
Labels
None yet
Milestone
v0.20
Development

Successfully merging this pull request may close these issues.
2 participants
@jawid-h @shumkov