Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

fix: subscribeToNewTransactions doesn't emit instant lock in some cases #384

Merged
merged 13 commits into from
Jul 14, 2021
Merged

fix: subscribeToNewTransactions doesn't emit instant lock in some cases #384

merged 13 commits into from
Jul 14, 2021

Conversation

shuplenkov
Copy link
Member

@shuplenkov shuplenkov commented Jul 12, 2021 •
edited by shumkov
Loading

Issue being fixed or feature implemented

In some rare cases, instant locks are not emitted in subscribeToNewTransactions endpoints, which leads to timeouts errors in dashmate

What was done?

  • Removed unnecessary Core RPC calls
  • Buffer instant locks while mempool and historical transactions are sending

How Has This Been Tested?

By running Dashmate

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov requested a review from shumkov July 12, 2021 09:23
@shuplenkov shuplenkov requested a review from antouhou July 12, 2021 10:40
@shuplenkov shuplenkov added this to the v0.20 milestone Jul 12, 2021
shumkov
shumkov approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did it finally :) Great work! 👍

@shuplenkov shuplenkov merged commit c21fd32 into v0.20-dev Jul 14, 2021
@shuplenkov shuplenkov deleted the fix-instantlock-timeout branch July 14, 2021 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shumkov shumkov shumkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Milestone
v0.20
Development

Successfully merging this pull request may close these issues.
3 participants
@shuplenkov @shumkov @antouhou