Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail with dask 2024.11.2 #1003

Open
GaetanLepage opened this issue Nov 25, 2024 · 1 comment · May be fixed by #1004
Open

Tests fail with dask 2024.11.2 #1003

GaetanLepage opened this issue Nov 25, 2024 · 1 comment · May be fixed by #1004

Comments

@GaetanLepage
Copy link
Contributor

Describe the issue:

Some tests are failing since we bumped dask to 2024.11.2:

=========================== short test summary info ============================
FAILED tests/model_selection/test_hyperband.py::test_basic[numpy-ConstantFunction-20] - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-74...
FAILED tests/model_selection/test_hyperband.py::test_hyperband_patience - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-78...
FAILED tests/model_selection/test_hyperband.py::test_same_random_state_same_params - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-dd...
FAILED tests/model_selection/test_incremental.py::test_explicit - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-ba...
FAILED tests/model_selection/test_incremental.py::test_search_basic - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-b2...
FAILED tests/model_selection/test_incremental.py::test_search_plateau_patience - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-e9...
FAILED tests/model_selection/test_incremental.py::test_search_plateau_tol - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-55...
FAILED tests/model_selection/test_incremental.py::test_gridsearch - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-30...
FAILED tests/model_selection/test_incremental.py::test_numpy_array - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-12...
FAILED tests/model_selection/test_incremental.py::test_transform - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-4a...
FAILED tests/model_selection/test_incremental.py::test_small - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-16...
FAILED tests/model_selection/test_incremental.py::test_smaller - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-11...
FAILED tests/model_selection/test_incremental.py::test_high_performing_models_are_retained_with_patience - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-1d...
FAILED tests/model_selection/test_incremental.py::test_same_params_with_random_state - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-68...
FAILED tests/model_selection/test_incremental.py::test_model_random_determinism - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-e6...
FAILED tests/model_selection/test_incremental.py::test_history - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-bd...
FAILED tests/model_selection/test_incremental.py::test_verbosity[True-IncrementalSearchCV] - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-08...
FAILED tests/model_selection/test_incremental.py::test_verbosity[False-IncrementalSearchCV] - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-02...
FAILED tests/model_selection/test_incremental.py::test_verbosity_types - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-28...
FAILED tests/model_selection/test_incremental.py::test_verbosity_levels[0] - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-a0...
FAILED tests/model_selection/test_incremental.py::test_verbosity_levels[0.0] - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-17...
FAILED tests/model_selection/test_incremental.py::test_verbosity_levels[0.5] - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-a2...
FAILED tests/model_selection/test_incremental.py::test_verbosity_levels[1] - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-05...
FAILED tests/model_selection/test_incremental.py::test_verbosity_levels[1.0] - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-32...
FAILED tests/model_selection/test_incremental.py::test_verbosity_levels[False] - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-78...
FAILED tests/model_selection/test_incremental.py::test_verbosity_levels[True] - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-2c...
FAILED tests/model_selection/test_incremental.py::test_search_patience_infeasible_tol - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-db...
FAILED tests/model_selection/test_incremental.py::test_search_invalid_patience - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-62...
FAILED tests/model_selection/test_incremental.py::test_model_future - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-88...
FAILED tests/model_selection/test_incremental_warns.py::test_warns_decay_rate - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-09...
FAILED tests/model_selection/test_incremental_warns.py::test_warns_decay_rate_wanted - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-a8...
FAILED tests/model_selection/test_successive_halving.py::test_sha_max_iter_and_metadata[9-2] - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-3e...
FAILED tests/model_selection/test_successive_halving.py::test_sha_max_iter_and_metadata[22-2] - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-ad...
FAILED tests/model_selection/test_successive_halving.py::test_search_patience_infeasible_tol - RuntimeError: Not enough arguments provided: missing keys {'_partial_fit-b5...
= 34 failed, 561 passed, 115 skipped, 4 deselected, 7 xfailed, 4 xpassed, 127 warnings in 165.71s (0:02:45) =

Minimal Complete Verifiable Example:

$ pytest

Anything else we need to know?:

Environment:

  • Dask version: 2024.11.2
  • Python version: 3.12.7
  • Operating System: NixOS
  • Install method (conda, pip, source): source (nixpkgs)
@GaetanLepage GaetanLepage mentioned this issue Nov 25, 2024
Merged
13 tasks
@TomAugspurger
Copy link
Member

TomAugspurger commented Nov 25, 2024 •
edited
Loading

xref dask/distributed#8948

TomAugspurger added a commit to TomAugspurger/dask-ml that referenced this issue Nov 26, 2024
@TomAugspurger
Avoid persisting Futures
b93d6dc 
Closes dask#1003
@TomAugspurger TomAugspurger linked a pull request Nov 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid persisting Futures TomAugspurger/dask-ml
2 participants
@TomAugspurger @GaetanLepage