From 1c09015e5f472936163451c563f454d4b62fe0e5 Mon Sep 17 00:00:00 2001 From: Noah Paige <69586985+noah-paige@users.noreply.github.com> Date: Thu, 27 Jun 2024 04:16:14 -0400 Subject: [PATCH] fix listOrganizationGroupPermissions (#1369) ### Feature or Bugfix - Bugfix ### Detail - Fix listOrganizationGroupPermissions ### Relates - ### Security Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --- backend/dataall/core/organizations/api/resolvers.py | 2 +- .../services/listOrganizationGroupPermissions.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/backend/dataall/core/organizations/api/resolvers.py b/backend/dataall/core/organizations/api/resolvers.py index 5d293e41f..b0651763d 100644 --- a/backend/dataall/core/organizations/api/resolvers.py +++ b/backend/dataall/core/organizations/api/resolvers.py @@ -92,7 +92,7 @@ def resolve_organization_by_env(context, source, **kwargs): def list_group_organization_permissions(context, source, organizationUri, groupUri): - return OrganizationService.list_group_organization_permissions(organizationUri, groupUri) + return OrganizationService.list_group_organization_permissions(uri=organizationUri, groupUri=groupUri) def list_invited_organization_permissions_with_descriptions(context, source): diff --git a/frontend/src/modules/Organizations/services/listOrganizationGroupPermissions.js b/frontend/src/modules/Organizations/services/listOrganizationGroupPermissions.js index 7de6dbb23..b74020a06 100644 --- a/frontend/src/modules/Organizations/services/listOrganizationGroupPermissions.js +++ b/frontend/src/modules/Organizations/services/listOrganizationGroupPermissions.js @@ -10,8 +10,8 @@ export const listOrganizationGroupPermissions = ({ }, query: gql` query listOrganizationGroupPermissions( - $organizationUri: String - $groupUri: String + $organizationUri: String! + $groupUri: String! ) { listOrganizationGroupPermissions( organizationUri: $organizationUri