Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sharing notifications #291

Closed
dlpzx opened this issue Feb 3, 2023 · 4 comments
Closed

Improve sharing notifications #291

dlpzx opened this issue Feb 3, 2023 · 4 comments
Labels
good first issue Good for newcomers priority: medium status: not-picked-yet At the moment we have not picked this item. Anyone can pick it up type: enhancement Feature enhacement

Comments

@dlpzx
Copy link
Contributor

dlpzx commented Feb 3, 2023

Currently sharing notifications inform me about the user that has approved a request and the target Dataset. I am missing information about the requester that got access and maybe the number of tables/folders shared.

Also there are only 2 types of notifications: approved or rejected. I would like to be informed about the success or failure of the sharing.

Describe the solution you'd like
I would like more types of notifications:

  • approve: already implemented
  • reject: already implemented
  • revoke
  • processed (maybe with failure/success information)

And in the notifications I would like to obtain information about:

  • Dataset: already implemented
  • Approver: already implemented
  • Requester
  • Number of tables/fodlers
@dlpzx dlpzx added the type: enhancement Feature enhacement label Feb 3, 2023
@dlpzx dlpzx mentioned this issue Feb 3, 2023
Merged
@dlpzx
Copy link
Contributor Author

dlpzx commented Feb 13, 2023

Related to #166

@dlpzx dlpzx added status: not-picked-yet At the moment we have not picked this item. Anyone can pick it up priority: medium good first issue Good for newcomers labels Feb 13, 2023
@dlpzx
Copy link
Contributor Author

dlpzx commented Aug 2, 2023

Take a look at dataall/cdkproxy/stacks/environment.py , there is already a "subscriptions" construct that could be helpful
image

@dlpzx
Copy link
Contributor Author

dlpzx commented Oct 24, 2023

This issue can be close as it is done in #822 and #818

@anmolsgandhi
Copy link
Contributor

Closing this issue in favor of #822 and #818

@dlpzx dlpzx mentioned this issue Jan 12, 2024
Open
@dlpzx dlpzx moved this to Done in Data.all Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers priority: medium status: not-picked-yet At the moment we have not picked this item. Anyone can pick it up type: enhancement Feature enhacement
Projects
Data.all Backlog
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlpzx @anmolsgandhi