Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: old op name LogicalGet can modify to Scan #15218

Closed
TCeason opened this issue Apr 11, 2024 · 1 comment · Fixed by #15222
Closed

chore: old op name LogicalGet can modify to Scan #15218

TCeason opened this issue Apr 11, 2024 · 1 comment · Fixed by #15222
Assignees
Labels
good first issue Category: good first issue

Comments

@TCeason
Copy link
Collaborator

TCeason commented Apr 11, 2024

          Note: it's an old name. Better to modify to Scan in a new issue.
fn try_from(value: RelOperator) -> Result<Self> {
        if let RelOperator::Scan(value) = value {
            Ok(value)
        } else {
            Err(ErrorCode::Internal(
                "Cannot downcast RelOperator to LogicalGet",
            ))
        }
    }

Originally posted by @TCeason in #15215 (comment)

@TracyZYJ
Copy link
Contributor

Please assign me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Category: good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants