Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe rename DataType::Utf8 to a more reasonable name? #1601

Closed
leiysky opened this issue Aug 25, 2021 · 5 comments
Closed

Maybe rename DataType::Utf8 to a more reasonable name? #1601

leiysky opened this issue Aug 25, 2021 · 5 comments
Labels
C-improvement Category: improvement

Comments

@leiysky
Copy link
Contributor

leiysky commented Aug 25, 2021

Seems this name came from LargeUtf8 in arrow.

It looks a little bit weird since in databases like Postgres or MySQL collation and charset are seperated from types. In this case, CHAR(string) is a data type and utf8 is a charset.

We can only support utf8 charset for now, but IMO maybe it's more reasonable to rename DataType::Utf8 to String or StringUtf8?

@leiysky leiysky added the C-question Category: question label Aug 25, 2021
@leiysky
Copy link
Contributor Author

leiysky commented Aug 25, 2021

cc @sundy-li

@sundy-li
Copy link
Member

sundy-li commented Aug 25, 2021

Maybe remove DataType::Utf8 and let's keep DataType::Binary as DataType::String, this could support more charset datatypes.

@leiysky leiysky self-assigned this Aug 25, 2021
@leiysky leiysky added C-improvement Category: improvement and removed C-question Category: question labels Aug 25, 2021
@leiysky
Copy link
Contributor Author

leiysky commented Aug 25, 2021

@sundy-li It seems there has been many macros and utility of both DataType::Utf8 and DataType::Binary, do you have any idea about how to deal with them?

@sundy-li
Copy link
Member

Let's do it in #1603

@leiysky leiysky removed their assignment Aug 25, 2021
@leiysky
Copy link
Contributor Author

leiysky commented Aug 25, 2021

Duplicated with #1603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-improvement Category: improvement
Projects
None yet
Development

No branches or pull requests

2 participants