-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maybe rename DataType::Utf8
to a more reasonable name?
#1601
Labels
C-improvement
Category: improvement
Comments
cc @sundy-li |
Maybe remove |
leiysky
added
C-improvement
Category: improvement
and removed
C-question
Category: question
labels
Aug 25, 2021
@sundy-li It seems there has been many macros and utility of both |
Let's do it in #1603 |
Duplicated with #1603 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Seems this name came from
LargeUtf8
in arrow.It looks a little bit weird since in databases like Postgres or MySQL collation and charset are seperated from types. In this case,
CHAR
(string) is a data type andutf8
is a charset.We can only support utf8 charset for now, but IMO maybe it's more reasonable to rename
DataType::Utf8
toString
orStringUtf8
?The text was updated successfully, but these errors were encountered: