From e205e65da292ac1078aca14dab6bbc7d05ffa148 Mon Sep 17 00:00:00 2001 From: JackTan25 Date: Wed, 4 Oct 2023 22:22:34 +0800 Subject: [PATCH] add push down comments --- src/query/sql/src/planner/binder/merge_into.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/query/sql/src/planner/binder/merge_into.rs b/src/query/sql/src/planner/binder/merge_into.rs index b198a9b8648cb..54b7ebc1f100e 100644 --- a/src/query/sql/src/planner/binder/merge_into.rs +++ b/src/query/sql/src/planner/binder/merge_into.rs @@ -128,7 +128,6 @@ impl Binder { self.bind_single_table(bind_context, &source_data).await?; // add all left source columns for read - // todo: (JackTan25) do column prune after finish "split expr for target and source" let mut columns_set = left_context.column_set(); let update_columns_star = if self.has_star_clause(&matched_clauses, &unmatched_clauses) { @@ -511,4 +510,9 @@ impl Binder { } false } + + // target_only_expr rules: + // we need to find all exprs in matched/unmatched clauses' [AND expr]. + // split all exprs which is correlated to target table and push down these + // expr to filter data of target table. }