Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CREATE_FOREIGN_CATALOG instead of CREATE_FOREIGN_SCURABLE with HMS federation enablement commands #3309

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use CREATE_FOREIGN_CATALOG instead of CREATE_FOREIGN_SCURABLE with HMS federation enablement commands #3309

wants to merge 3 commits into from

Conversation

FastLee
Copy link
Contributor

@FastLee FastLee commented Nov 14, 2024

closes #3308

@FastLee FastLee requested a review from a team as a code owner November 14, 2024 22:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

✅ 54/54 passed, 1 flaky, 4 skipped, 1h49m9s total

Flaky tests:

  • 🤪 test_migration_job_ext_hms[regular] (4m59.044s)

Running from acceptance #7390

nfx
nfx approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/databricks/labs/ucx/hive_metastore/federation.py Outdated Show resolved Hide resolved
@nfx nfx changed the title Replaced CREATE_FOREIGN_CATALOG with CREATE_FOREIGN_SCURABLE Use CREATE_FOREIGN_CATALOG instead of CREATE_FOREIGN_SCURABLE with HMS federation enablement commands Nov 18, 2024
@nfx nfx added the ready to merge this pull request is ready to merge label Nov 18, 2024
@nfx nfx enabled auto-merge November 18, 2024 11:03
@nfx nfx removed the ready to merge this pull request is ready to merge label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfx nfx nfx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: HMS Federation is using "CREATE_FOREIGN_SECURABLE" instead of "CREATE_FOREIGN_CATALOG"
2 participants
@FastLee @nfx