Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compatibility] add version for flight rpc talking #1247

Closed
BohuTANG opened this issue Jul 31, 2021 · 1 comment
Closed

[Compatibility] add version for flight rpc talking #1247

BohuTANG opened this issue Jul 31, 2021 · 1 comment
Labels
C-improvement Category: improvement

Comments

@BohuTANG
Copy link
Member

BohuTANG commented Jul 31, 2021

Summary

For example,

1. The init versions: fusequery-1 version is v1, and fusequery-2 is v1, fusestore version is v1
2. We upgrade fusequery-2 and the version to v2
3. So the talking between fusequery-1 and fusequery-2 may has some problems in protocol 
4. Also, this may has problems between fusequery and fusestore in protocol

We can strictly limit the version:

 if self.version != other.version {return error}

When need update the rpc version:

We change the rpc protocol, which may result in incompatibility
@BohuTANG BohuTANG added the C-improvement Category: improvement label Jul 31, 2021
@BohuTANG BohuTANG added this to the v0.5 milestone Jul 31, 2021
@BohuTANG BohuTANG removed this from the v0.5 milestone Oct 29, 2021
@Xuanwo
Copy link
Member

Xuanwo commented Jul 2, 2022

Already covered by meta. Let's closing.

@Xuanwo Xuanwo closed this as completed Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-improvement Category: improvement
Projects
None yet
Development

No branches or pull requests

2 participants