feat: Introducing optional DataPlatform logo url (#2127)

Co-authored-by: John Joyce <[email protected]>
datahub-project · Feb 20, 2021 · 4f8d8b3 · 4f8d8b3
1 parent b9e9a08
commit 4f8d8b3
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 1 deletion.
diff --git a/...core/src/main/java/com/linkedin/datahub/graphql/types/mappers/DataPlatformInfoMapper.java b/...core/src/main/java/com/linkedin/datahub/graphql/types/mappers/DataPlatformInfoMapper.java
@@ -18,6 +18,9 @@ public DataPlatformInfo apply(@Nonnull final com.linkedin.dataplatform.DataPlatf
         final DataPlatformInfo result = new DataPlatformInfo();
         result.setType(PlatformType.valueOf(input.getType().toString()));
         result.setDatasetNameDelimiter(input.getDatasetNameDelimiter());
+        if (input.hasLogoUrl()) {
+            result.setLogoUrl(input.getLogoUrl().toString());
+        }
         return result;
     }
 }
diff --git a/datahub-graphql-core/src/main/resources/gms.graphql b/datahub-graphql-core/src/main/resources/gms.graphql
@@ -239,6 +239,11 @@ type DataPlatformInfo {
     The delimiter in the dataset names on the data platform
     """
     datasetNameDelimiter: String!
+
+    """
+    A logo URL associated with the platform
+    """
+    logoUrl: String
 }
 
 enum PlatformType {

diff --git a/gms/api/src/main/snapshot/com.linkedin.dataplatform.dataPlatforms.snapshot.json b/gms/api/src/main/snapshot/com.linkedin.dataplatform.dataPlatforms.snapshot.json
@@ -27,6 +27,15 @@
         "owningTeam" : "urn:li:internalTeam:wherehows"
       }
     }
+  }, {
+    "type" : "typeref",
+    "name" : "Url",
+    "namespace" : "com.linkedin.common",
+    "ref" : "string",
+    "java" : {
+      "class" : "com.linkedin.common.url.Url",
+      "coercerClass" : "com.linkedin.common.url.UrlCoercer"
+    }
   }, {
     "type" : "record",
     "name" : "DataPlatform",
@@ -76,6 +85,10 @@
           "name" : "datasetNameDelimiter",
           "type" : "string",
           "doc" : "The delimiter in the dataset names on the data platform, e.g. '/' for HDFS and '.' for Oracle"
+        }, {
+          "name" : "logoUrl",
+          "type" : "com.linkedin.common.Url",
+          "optional" : true
         } ]
       },
       "doc" : "Metadata associated with a dataplatform information",

diff --git a/gms/api/src/main/snapshot/com.linkedin.ml.mlModels.snapshot.json b/gms/api/src/main/snapshot/com.linkedin.ml.mlModels.snapshot.json
@@ -1453,4 +1453,4 @@
       }
     }
   }
-}
+}
diff --git a/metadata-models/src/main/pegasus/com/linkedin/dataplatform/DataPlatformInfo.pdl b/metadata-models/src/main/pegasus/com/linkedin/dataplatform/DataPlatformInfo.pdl
@@ -1,5 +1,7 @@
 namespace com.linkedin.dataplatform
 
+import com.linkedin.common.Url
+
 /**
  * Information about a data platform
  */
@@ -70,4 +72,9 @@ record DataPlatformInfo {
    * The delimiter in the dataset names on the data platform, e.g. '/' for HDFS and '.' for Oracle
    */
   datasetNameDelimiter: string
+
+  /**
+   * The URL for a logo associated with the platform
+   */
+  logoUrl: optional Url
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -1453,4 +1453,4 @@ @@
           }
         }
       }
-    }
+    }