1604086049622-ui-sync (#1981)

Co-authored-by: Ignacio Bona <[email protected]>

datahub-web/.eslintignore

@@ -24,7 +24,7 @@
 
 # TODO [META-12204] Fix issues in datahub/pdsc that make us have to ignore the directory
 # vendor generator for metadata-models TypeScript type definitions
-**/@datahub/pdsc/
+**/@dh-tools/pdsc/
 
 # generated metadata-models TypeScript type definitions
 **/types/codegen/**/*.d.ts

datahub-web/.eslintrc.js

@@ -39,11 +39,11 @@ module.exports = {
     '@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
     'prettier/prettier': ['error', { singleQuote: true, printWidth: 120 }],
     'ember/no-ember-super-in-es-classes': 'error',
-    '@datahub/no-addon-import': 'error',
-    '@datahub/no-linkedin-import': 'warn',
+    '@dh-tools/no-addon-import': 'error',
+    '@dh-tools/no-linkedin-import': 'warn',
     eqeqeq: ['error', 'always']
   },
-  plugins: ['prettier', 'ember', '@typescript-eslint', '@datahub'],
+  plugins: ['prettier', 'ember', '@typescript-eslint', '@dh-tools'],
   overrides: [
     // node files
     {
@@ -78,7 +78,7 @@ module.exports = {
         'packages/data-portal-internal-clone/**/*.js'
       ],
       rules: {
-        '@datahub/no-linkedin-import': 'off'
+        '@dh-tools/no-linkedin-import': 'off'
       }
     }
   ]

datahub-web/@datahub/data-models/addon/constants/entity/dataset/tab-properties/properties.ts

@@ -1,6 +1,6 @@
 import { ITabProperties } from '@datahub/data-models/types/entity/rendering/entity-render-props';
 import { DatasetTab } from '@datahub/data-models/constants/entity/dataset/tabs';
-import { INachoTableConfigs } from '@nacho-ui/table/types/nacho-table';
+import { INachoTableConfigs } from '@nacho-ui/core/types/nacho-table';
 import { DatasetEntity } from '@datahub/data-models/entity/dataset/dataset-entity';
 
 /**

datahub-web/@datahub/data-models/addon/entity/base-entity.ts

@@ -31,7 +31,7 @@ import {
 } from '@datahub/data-models/api/common/social-actions';
 import { DataModelName } from '@datahub/data-models/constants/entity';
 import { getDefaultIfNotFoundError } from '@datahub/utils/api/error';
-import { noop } from 'lodash';
+import { noop } from 'lodash-es';
 import { aspect, setAspect } from '@datahub/data-models/entity/utils/aspects';
 
 /**

datahub-web/@datahub/data-models/addon/entity/dataset/helpers/validators/base.ts

@@ -1,5 +1,5 @@
 import { IMetadataType } from '@datahub/data-models/types/entity/validators';
-import { every, difference } from 'lodash';
+import { every, difference } from 'lodash-es';
 import { typeOf } from '@ember/utils';
 import { isObject } from '@datahub/utils/validators/object';
 

datahub-web/@datahub/data-models/addon/entity/dataset/helpers/validators/compliance/analyze-diff.ts

@@ -1,5 +1,5 @@
 import DatasetComplianceAnnotation from '@datahub/data-models/entity/dataset/modules/compliance-annotation';
-import { groupBy, uniq } from 'lodash';
+import { groupBy, uniq } from 'lodash-es';
 import { annotationsMatchByRelevantKeys } from '@datahub/data-models/entity/dataset/helpers/validators/compliance/comparators';
 
 /**

datahub-web/@datahub/data-models/addon/entity/dataset/modules/compliance-annotation.ts

@@ -3,7 +3,7 @@ import { annotationIsValid } from '@datahub/data-models/entity/dataset/modules/c
 import { set, setProperties, computed } from '@ember/object';
 import { ComplianceAnnotationsEditableProps } from '@datahub/data-models/entity/dataset/helpers/validators/compliance/annotations';
 import { IComplianceDataType } from '@datahub/metadata-types/types/entity/dataset/compliance-data-types';
-import { pick, omit, isEqual } from 'lodash';
+import { pick, omit, isEqual } from 'lodash-es';
 /**
  * Creates a basic factory to generate default values for a compliance annotation tag. This class is created both to
  * translate the API response for annotations as well as when the user initiates the creation of a new tag from the UI. In

datahub-web/@datahub/data-models/addon/entity/dataset/modules/compliance-info.ts

@@ -19,7 +19,7 @@ import { computed } from '@ember/object';
 import { applyAnnotationsByEditableProperties } from '@datahub/data-models/entity/dataset/modules/constants/annotation-helpers';
 import DatasetSchema from '@datahub/data-models/entity/dataset/modules/schema';
 import { filterAnnotationsToDatasetSchema } from '@datahub/data-models/entity/dataset/helpers/validators/compliance/schema';
-import { omit } from 'lodash';
+import { omit } from 'lodash-es';
 import { IComplianceAnnotationUpdates } from '@datahub/data-models/types/entity/dataset';
 
 interface IReadWorkingComplianceOptions {

datahub-web/@datahub/data-models/addon/entity/dataset/modules/constants/annotation-helpers.ts

@@ -9,7 +9,7 @@ import {
 } from '@datahub/data-models/entity/dataset/helpers/validators/compliance/annotations';
 import { setProperties } from '@ember/object';
 import { IComplianceFieldAnnotation } from '@datahub/metadata-types/constants/entity/dataset/compliance-field-annotation';
-import { pick } from 'lodash';
+import { pick } from 'lodash-es';
 import { IComplianceDataType } from '@datahub/metadata-types/types/entity/dataset/compliance-data-types';
 
 /**

datahub-web/@datahub/data-models/addon/entity/dataset/modules/export-policy.ts

@@ -1,7 +1,8 @@
 import { IDatasetExportPolicy } from '@datahub/metadata-types/types/entity/dataset/compliance/export-policy';
 import { alias } from '@ember/object/computed';
 import { setProperties } from '@ember/object';
-import { Omit, omit } from 'lodash';
+import { omit } from 'lodash-es';
+import { Omit } from 'lodash';
 import { arrayEvery } from '@datahub/utils/array/every';
 import { computed } from '@ember/object';
 

datahub-web/@datahub/data-models/package.json

@@ -25,24 +25,20 @@
   },
   "dependencies": {
     "@datahub/metadata-types": "0.0.0",
-    "@datahub/utils": "0.0.0",
-    "@types/ember-resolver": "^5.0.7",
-    "@nacho-ui/core": "^0.0.38",
+    "@glimmer/component": "^1.0.2",
+    "@glimmer/tracking": "^1.0.2",
+    "ember-auto-import": "^1.5.3",
     "ember-cli-babel": "^7.17.2",
     "ember-cli-htmlbars": "^4.2.2",
     "ember-cli-typescript": "^3.1.3",
-    "ember-fetch": "^7.0.0",
-    "ember-lodash": "^4.18.0",
-    "faker": "^4.1.0",
-    "ember-cli-eyeglass": "^6.4.3"
+    "faker": "^4.1.0"
   },
   "devDependencies": {
     "@babel/core": "^7.8.4",
     "@ember/optional-features": "^1.3.0",
-    "@glimmer/component": "^1.0.0",
-    "@glimmer/tracking": "^1.0.0",
     "@types/ember": "^3.1.1",
     "@types/ember-qunit": "^3.4.7",
+    "@types/ember-resolver": "^5.0.7",
     "@types/ember-test-helpers": "^1.0.5",
     "@types/ember-testing-helpers": "^0.0.3",
     "@types/ember__test-helpers": "^0.7.9",
@@ -51,15 +47,14 @@
     "@types/sinon": "^7.0.3",
     "babel-eslint": "^10.0.3",
     "broccoli-asset-rev": "^3.0.0",
-    "ember-auto-import": "^1.5.3",
-    "ember-cli": "~3.16.0",
+    "ember-cli": "~3.22.0",
     "ember-cli-dependency-checker": "^3.2.0",
+    "ember-cli-eyeglass": "^6.4.3",
     "ember-cli-inject-live-reload": "^2.0.2",
     "ember-cli-mirage": "^0.4.15",
     "ember-cli-sri": "^2.1.1",
     "ember-cli-typescript-blueprints": "^3.0.0",
     "ember-cli-uglify": "^3.0.0",
-    "ember-cli-update": "^0.52.1",
     "ember-decorators": "^6.0.0",
     "ember-export-application-global": "^2.0.1",
     "ember-load-initializers": "^2.1.1",

datahub-web/@datahub/data-models/tsconfig.json

@@ -16,8 +16,8 @@
       "@datahub/utils/*": ["../../@datahub/utils/addon/*"],
       "@datahub/metadata-types": ["../../@datahub/metadata-types/addon"],
       "@datahub/metadata-types/*": ["../../@datahub/metadata-types/addon/*"],
-      "@nacho-ui/core": ["../../@nacho-ui/nacho-core/addon"],
-      "@nacho-ui/core/*": ["../../@nacho-ui/nacho-core/addon/*"],
+      "@nacho-ui/core": ["../../@nacho-ui/core/addon"],
+      "@nacho-ui/core/*": ["../../@nacho-ui/core/addon/*"],
       "*": ["types/*"]
     }
   },
@@ -32,6 +32,6 @@
     "../../@datahub/metadata-types/types/**/*",
     "../../@datahub/utils/addon/**/*",
     "../../@datahub/utils/types/**/*",
-    "../../@nacho-ui/nacho-core/**/*"
+    "../../@nacho-ui/core/**/*"
   ]
 }

datahub-web/@datahub/data-models/types/entity/rendering/page-components.d.ts

@@ -1,4 +1,4 @@
-import { INachoTableConfigs } from '@nacho-ui/table/types/nacho-table';
+import { INachoTableConfigs } from '@nacho-ui/core/types/nacho-table';
 import { KeyNamesWithValueType } from '@datahub/utils/types/base';
 import { IDynamicComponent } from '@datahub/shared/types/dynamic-component';
 import { IStandardDynamicProperty } from '@datahub/data-models/types/entity/rendering/properties-panel';