From ece09f502d0b8c4a735e489387fb960d0d2173e0 Mon Sep 17 00:00:00 2001 From: Ellie O'Neil Date: Thu, 9 May 2024 08:29:59 -0700 Subject: [PATCH 1/3] add fabric type rvw --- datahub-graphql-core/src/main/resources/entity.graphql | 5 +++++ li-utils/src/main/pegasus/com/linkedin/common/FabricType.pdl | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/datahub-graphql-core/src/main/resources/entity.graphql b/datahub-graphql-core/src/main/resources/entity.graphql index 296d62bc534a3a..1f2642567b49ec 100644 --- a/datahub-graphql-core/src/main/resources/entity.graphql +++ b/datahub-graphql-core/src/main/resources/entity.graphql @@ -2685,6 +2685,11 @@ enum FabricType { Designates corporation fabrics """ CORP + + """ + Designates review fabrics + """ + RVW } """ diff --git a/li-utils/src/main/pegasus/com/linkedin/common/FabricType.pdl b/li-utils/src/main/pegasus/com/linkedin/common/FabricType.pdl index c5959ac4cc8fa9..366843e460cb35 100644 --- a/li-utils/src/main/pegasus/com/linkedin/common/FabricType.pdl +++ b/li-utils/src/main/pegasus/com/linkedin/common/FabricType.pdl @@ -54,4 +54,9 @@ enum FabricType { * Designates corporation fabrics */ CORP + + /** + * Designates review fabrics + */ + RVW } From 1933bc9cffbd0ae5aa3cbc196abafe9c8fe5315f Mon Sep 17 00:00:00 2001 From: Ellie O'Neil Date: Thu, 9 May 2024 09:27:04 -0700 Subject: [PATCH 2/3] modify generated files --- .../main/snapshot/com.linkedin.entity.aspects.snapshot.json | 5 +++-- .../main/snapshot/com.linkedin.entity.entities.snapshot.json | 5 +++-- .../src/main/snapshot/com.linkedin.entity.runs.snapshot.json | 5 +++-- .../com.linkedin.operations.operations.snapshot.json | 5 +++-- .../snapshot/com.linkedin.platform.platform.snapshot.json | 5 +++-- 5 files changed, 15 insertions(+), 10 deletions(-) diff --git a/metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.json b/metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.json index becdcdd0215fde..00b434d30356f9 100644 --- a/metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.json +++ b/metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.json @@ -834,7 +834,7 @@ "name" : "FabricType", "namespace" : "com.linkedin.common", "doc" : "Fabric group type", - "symbols" : [ "DEV", "TEST", "QA", "UAT", "EI", "PRE", "STG", "NON_PROD", "PROD", "CORP" ], + "symbols" : [ "DEV", "TEST", "QA", "UAT", "EI", "PRE", "STG", "NON_PROD", "PROD", "CORP", "RVW" ], "symbolDocs" : { "CORP" : "Designates corporation fabrics", "DEV" : "Designates development fabrics", @@ -845,7 +845,8 @@ "QA" : "Designates quality assurance fabrics", "STG" : "Designates staging fabrics", "TEST" : "Designates testing fabrics", - "UAT" : "Designates user acceptance testing fabrics" + "UAT" : "Designates user acceptance testing fabrics", + "RVW" : "Designates review fabrics" } }, { "type" : "record", diff --git a/metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.json b/metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.json index 96b9b570b2bf18..ffbcdd1b2adb3b 100644 --- a/metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.json +++ b/metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.json @@ -834,7 +834,7 @@ "name" : "FabricType", "namespace" : "com.linkedin.common", "doc" : "Fabric group type", - "symbols" : [ "DEV", "TEST", "QA", "UAT", "EI", "PRE", "STG", "NON_PROD", "PROD", "CORP" ], + "symbols" : [ "DEV", "TEST", "QA", "UAT", "EI", "PRE", "STG", "NON_PROD", "PROD", "CORP", "RVW" ], "symbolDocs" : { "CORP" : "Designates corporation fabrics", "DEV" : "Designates development fabrics", @@ -845,7 +845,8 @@ "QA" : "Designates quality assurance fabrics", "STG" : "Designates staging fabrics", "TEST" : "Designates testing fabrics", - "UAT" : "Designates user acceptance testing fabrics" + "UAT" : "Designates user acceptance testing fabrics", + "RVW" : "Designates review fabrics" } }, { "type" : "record", diff --git a/metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.runs.snapshot.json b/metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.runs.snapshot.json index 6100073f1fbc91..0139072b2ae153 100644 --- a/metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.runs.snapshot.json +++ b/metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.runs.snapshot.json @@ -576,7 +576,7 @@ "name" : "FabricType", "namespace" : "com.linkedin.common", "doc" : "Fabric group type", - "symbols" : [ "DEV", "TEST", "QA", "UAT", "EI", "PRE", "STG", "NON_PROD", "PROD", "CORP" ], + "symbols" : [ "DEV", "TEST", "QA", "UAT", "EI", "PRE", "STG", "NON_PROD", "PROD", "CORP", "RVW" ], "symbolDocs" : { "CORP" : "Designates corporation fabrics", "DEV" : "Designates development fabrics", @@ -587,7 +587,8 @@ "QA" : "Designates quality assurance fabrics", "STG" : "Designates staging fabrics", "TEST" : "Designates testing fabrics", - "UAT" : "Designates user acceptance testing fabrics" + "UAT" : "Designates user acceptance testing fabrics", + "RVW" : "Designates review fabrics" } }, { "type" : "record", diff --git a/metadata-service/restli-api/src/main/snapshot/com.linkedin.operations.operations.snapshot.json b/metadata-service/restli-api/src/main/snapshot/com.linkedin.operations.operations.snapshot.json index 0573a342da4205..1caeed2570317e 100644 --- a/metadata-service/restli-api/src/main/snapshot/com.linkedin.operations.operations.snapshot.json +++ b/metadata-service/restli-api/src/main/snapshot/com.linkedin.operations.operations.snapshot.json @@ -576,7 +576,7 @@ "name" : "FabricType", "namespace" : "com.linkedin.common", "doc" : "Fabric group type", - "symbols" : [ "DEV", "TEST", "QA", "UAT", "EI", "PRE", "STG", "NON_PROD", "PROD", "CORP" ], + "symbols" : [ "DEV", "TEST", "QA", "UAT", "EI", "PRE", "STG", "NON_PROD", "PROD", "CORP", "RVW" ], "symbolDocs" : { "CORP" : "Designates corporation fabrics", "DEV" : "Designates development fabrics", @@ -587,7 +587,8 @@ "QA" : "Designates quality assurance fabrics", "STG" : "Designates staging fabrics", "TEST" : "Designates testing fabrics", - "UAT" : "Designates user acceptance testing fabrics" + "UAT" : "Designates user acceptance testing fabrics", + "RVW" : "Designates review fabrics" } }, { "type" : "record", diff --git a/metadata-service/restli-api/src/main/snapshot/com.linkedin.platform.platform.snapshot.json b/metadata-service/restli-api/src/main/snapshot/com.linkedin.platform.platform.snapshot.json index 4a1f24d527b89c..1592333988b4ca 100644 --- a/metadata-service/restli-api/src/main/snapshot/com.linkedin.platform.platform.snapshot.json +++ b/metadata-service/restli-api/src/main/snapshot/com.linkedin.platform.platform.snapshot.json @@ -834,7 +834,7 @@ "name" : "FabricType", "namespace" : "com.linkedin.common", "doc" : "Fabric group type", - "symbols" : [ "DEV", "TEST", "QA", "UAT", "EI", "PRE", "STG", "NON_PROD", "PROD", "CORP" ], + "symbols" : [ "DEV", "TEST", "QA", "UAT", "EI", "PRE", "STG", "NON_PROD", "PROD", "CORP", "RVW" ], "symbolDocs" : { "CORP" : "Designates corporation fabrics", "DEV" : "Designates development fabrics", @@ -845,7 +845,8 @@ "QA" : "Designates quality assurance fabrics", "STG" : "Designates staging fabrics", "TEST" : "Designates testing fabrics", - "UAT" : "Designates user acceptance testing fabrics" + "UAT" : "Designates user acceptance testing fabrics", + "RVW" : "Designates review fabrics" } }, { "type" : "record", From 79680529a38f89c41e365ad61350d0f4d1cb0af3 Mon Sep 17 00:00:00 2001 From: Ellie O'Neil Date: Thu, 9 May 2024 09:29:31 -0700 Subject: [PATCH 3/3] update docs --- docs/how/updating-datahub.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/how/updating-datahub.md b/docs/how/updating-datahub.md index f5b3600d983067..602341551ecd68 100644 --- a/docs/how/updating-datahub.md +++ b/docs/how/updating-datahub.md @@ -21,6 +21,7 @@ This file documents any backwards-incompatible changes in DataHub and assists pe ### Breaking Changes - #10419 - `aws_session_token` and `aws_region` are now required configurations in the DynamoDB connector. The connector will no longer loop through all AWS regions; instead, it will only use the region passed into the recipe configuration. +- #10472 - `RVW` added as a FabricType. No rollbacks allowed once metadata with this fabric type is added without manual cleanups in databases. ### Potential Downtime