feat(ingest/airflow): Add way to disable Airflow plugin without a restart #12098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
datahub-cyborg
bot
added
the
needs-review
hsheth2
requested changes
Dec 12, 2024
docs/lineage/airflow.md
Outdated
| @@ -80,6 +80,37 @@ enabled = True # default | |||
| | log_level | _no change_ | [debug] Set the log level for the plugin. | | |||
| | debug_emitter | false | [debug] If true, the plugin will log the emitted events. | | |||
|
|
|||
| #### Disabling the DataHub Plugin v2 | |||
There was a problem hiding this comment.
let's move these docs down to the "Debugging" section
| logger.info("DataHub listener disabled by kill switch") | ||
| return True | ||
| except Exception as e: | ||
| raise e |
There was a problem hiding this comment.
what's the point of this try catch?
| @@ -482,6 +496,10 @@ def on_task_instance_running( | |||
| def on_task_instance_finish( | |||
| self, task_instance: "TaskInstance", status: InstanceRunResult | |||
| ) -> None: | |||
| if self.check_kill_switch(): | |||
There was a problem hiding this comment.
this method is called by the success and failure hooks - so it doesn't need this
| @@ -556,6 +577,9 @@ def on_task_instance_success( | |||
| def on_task_instance_failed( | |||
| self, previous_state: None, task_instance: "TaskInstance", session: "Session" | |||
| ) -> None: | |||
| if self.check_kill_switch(): | |||
There was a problem hiding this comment.
we also need to add these to the on_dag_... methods
datahub-cyborg
bot
added
pending-submitter-response
datahub-cyborg
bot
added
needs-review
hsheth2
approved these changes
Dec 13, 2024
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist