feat(React Incubation): React Playground Proof of Concept #2059
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a React proof-of-concept under a new 'datahub-web-react' module. I chose to locate it there instead of /contrib because I've been testing serving this from
datahub-frontend
and gradle modules are required for that!Take a look around, explore! To run the mock server, run
yarn run start
from inside thedatahub-web-react
module. As of now, we are simply mocking GraphQL response data using Apollo MockProvider. You can find the request-response mocks under Mocks.tsx in /src directory. This can be changed using a variable in App.tsx if you want to hit a local datahub-frontend (but must have /graphql endpoint changes from my prev PRs).You'll notice that the reason we can work with type-safe GQL bindings is because I've provided a temporary GQL schema file directly within the react app directory (
datahub-frontend.graphql
). Once the other pending GQL PRs are in, this will be replaced by the .graphql file inside /datahub-frontend.Currently, most requests simply won't return any mocked data, try navigating to the following paths to see some content:
localhost:3000/logIn
localhost:3000/datasets/urn:li:dataset:1
localhost:3000/search?type=dataset&query=test
Notice that this is a major work-in-progress, many components need to be cleaned up & iterated on. Specifically we'll need to address styling convention (currently inlining styles, ew), testing convention, design, how we permit configurability / extensibility & more.
Some fun screenshots!
Checklist