Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(React): Adding Properties, Documentation tabs, user search, & supporting Dataset mutations #2093

Merged
merged 4 commits into from
Feb 9, 2021
Merged

feat(React): Adding Properties, Documentation tabs, user search, & supporting Dataset mutations #2093

merged 4 commits into from
Feb 9, 2021

Conversation

jjoyce0510
Copy link
Collaborator

@jjoyce0510 jjoyce0510 commented Feb 9, 2021 •
edited
Loading

Scope
This PR only changes the incubating React app. It is part of the initiative to achieve feature parity with the existing Ember app.

Changes
The PR introduces

  1. 2 new Dataset tabs: Properties + Documentation (institutional memory)
  2. Dataset Mutations: ability to persist new owners and new pieces of documentation into GMS
  3. User Search: User search tab now works.
  4. GraphQL API: Wired up the react app to the GQL API being served out of datahub-frontend. Now when executing "yarn run start" we will by default talk to Datahub-frontend server at localhost:9001 (so it needs to be up and running)

Properties

Screen Shot 2021-02-03 at 1 55 36 PM

Documentation

Screen Shot 2021-02-07 at 5 04 03 PM

Screen Shot 2021-02-07 at 5 04 13 PM

User Search

Screen Shot 2021-02-02 at 4 32 48 PM

Status
Ready for review

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@jjoyce0510 jjoyce0510 changed the title feat(React): Adding Properties, Documentation tabs, user search, & supporting mutations feat(React): Adding Properties, Documentation tabs, user search, & supporting Dataset mutations Feb 9, 2021
shirshanka
shirshanka approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@shirshanka shirshanka merged commit 2645aa0 into datahub-project:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjoyce0510 @shirshanka