Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DataPlatform): Introducing optional DataPlatform logoUrl field #2127

Merged
merged 1 commit into from
Feb 20, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ public DataPlatformInfo apply(@Nonnull final com.linkedin.dataplatform.DataPlatf
final DataPlatformInfo result = new DataPlatformInfo();
result.setType(PlatformType.valueOf(input.getType().toString()));
result.setDatasetNameDelimiter(input.getDatasetNameDelimiter());
if (input.hasLogoUrl()) {
result.setLogoUrl(input.getLogoUrl().toString());
}
return result;
}
}
5 changes: 5 additions & 0 deletions datahub-graphql-core/src/main/resources/gms.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,11 @@ type DataPlatformInfo {
The delimiter in the dataset names on the data platform
"""
datasetNameDelimiter: String!

"""
A logo URL associated with the platform
"""
logoUrl: String
}

enum PlatformType {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,15 @@
"owningTeam" : "urn:li:internalTeam:wherehows"
}
}
}, {
"type" : "typeref",
"name" : "Url",
"namespace" : "com.linkedin.common",
"ref" : "string",
"java" : {
"class" : "com.linkedin.common.url.Url",
"coercerClass" : "com.linkedin.common.url.UrlCoercer"
}
}, {
"type" : "record",
"name" : "DataPlatform",
Expand Down Expand Up @@ -76,6 +85,10 @@
"name" : "datasetNameDelimiter",
"type" : "string",
"doc" : "The delimiter in the dataset names on the data platform, e.g. '/' for HDFS and '.' for Oracle"
}, {
"name" : "logoUrl",
"type" : "com.linkedin.common.Url",
"optional" : true
} ]
},
"doc" : "Metadata associated with a dataplatform information",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1453,4 +1453,4 @@
}
}
}
}
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
namespace com.linkedin.dataplatform

import com.linkedin.common.Url

/**
* Information about a data platform
*/
Expand Down Expand Up @@ -70,4 +72,9 @@ record DataPlatformInfo {
* The delimiter in the dataset names on the data platform, e.g. '/' for HDFS and '.' for Oracle
*/
datasetNameDelimiter: string

/**
* The URL for a logo associated with the platform
*/
logoUrl: optional Url
}