feat(React): React App Analytics (WIP) #2435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
commented
Apr 29, 2021
| timestamp?: number; | ||
| urn?: string; | ||
| date?: string; | ||
| userAgent?: string; |
There was a problem hiding this comment.
deviceId --> also remember this is not a session token
shirshanka
reviewed
Apr 29, 2021
| */ | ||
| export interface BaseEvent { | ||
| type: EventType; | ||
| actor?: string; |
shirshanka
reviewed
Apr 29, 2021
| type: EventType; | ||
| actor?: string; | ||
| timestamp?: number; | ||
| urn?: string; |
|
Taking another pass to address comments & add additional tracking |
4 tasks
|
Closed via #2499 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
These changes only impact the React client.
Changes
This PR introduces a generalized analytics module for tracking:
inside the React app. With this PR, we will the ability to easily support to a variety of backend analytics providers like
& many others
We achieve this by building a small extension on top of the popular Analytics library, which supports many analytics providers out of the box.
In this PR, we introduce support for Google Analytics, Mixpanel, Amplitude, & a logging provider for testing, as well as implement a series of custom tracking events:
that will allow you to understand your users behavior on the DataHub platform.
As of now, configuring an analytics provider (plugin) requires changing code under the "plugins" directory of the analytics module inside
datahub-web-react. In a follow up PR, we intend to expose these configurations via environment variables on the datahub-frontend-react Docker container, allowing you to configure product analytics without modifying code.Status
Work in progress. Will be providing a richer README with details on supporting additional providers, configuring a provider, etc.
Example
Mixpanel Dashboard showing metrics collected using the framework.
Checklist